-
Notifications
You must be signed in to change notification settings - Fork 596
WIP: Local kind registry #12798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
timflannagan
wants to merge
1
commit into
kgateway-dev:main
Choose a base branch
from
timflannagan:chore/local-registry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
WIP: Local kind registry #12798
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,5 @@ controller: | |
| # rollingUpdate: | ||
| # maxSurge: 100% | ||
| # maxUnavailable: 100% | ||
| image: | ||
| registry: localhost:5001 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,8 @@ | ||
| kind: Cluster | ||
| apiVersion: kind.x-k8s.io/v1alpha4 | ||
| kubeadmConfigPatches: | ||
| - | | ||
| apiVersion: kubeadm.k8s.io/v1beta3 | ||
| kind: ClusterConfiguration | ||
| metadata: | ||
| name: config | ||
| - | | ||
| apiVersion: kubeadm.k8s.io/v1beta3 | ||
| kind: InitConfiguration | ||
| metadata: | ||
| name: config | ||
| kind: Cluster | ||
| containerdConfigPatches: | ||
| - |- | ||
| [plugins."io.containerd.grpc.v1.cri".registry] | ||
| config_path = "/etc/containerd/certs.d" | ||
| networking: | ||
| apiServerAddress: "127.0.0.1" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -o errexit | ||
| set -o pipefail | ||
|
|
||
| KIND_CLUSTER_NAME=${KIND_CLUSTER_NAME:-kind} | ||
| KIND_IMAGE_VERSION=${KIND_IMAGE_VERSION:-v1.34.0@sha256:7416a61b42b1662ca6ca89f02028ac133a309a2a30ba309614e8ec94d976dc5a} | ||
|
|
||
| # 1. Create registry container unless it already exists | ||
| reg_name='kind-registry' | ||
| reg_port='5001' | ||
| if [ "$(docker inspect -f '{{.State.Running}}' "${reg_name}" 2>/dev/null || true)" != 'true' ]; then | ||
| docker run \ | ||
| -d --restart=always -p "127.0.0.1:${reg_port}:5000" --network bridge --name "${reg_name}" \ | ||
| registry:2 | ||
| fi | ||
|
|
||
| # 2. Create kind cluster with containerd registry config dir enabled | ||
| # | ||
| # NOTE: the containerd config patch is not necessary with images from kind v0.27.0+ | ||
| # It may enable some older images to work similarly. | ||
| # If you're only supporting newer releases, you can just use `kind create cluster` here. | ||
| # | ||
| # See: | ||
| # https://github.com/kubernetes-sigs/kind/issues/2875 | ||
| # https://github.com/containerd/containerd/blob/main/docs/cri/config.md#registry-configuration | ||
| # See: https://github.com/containerd/containerd/blob/main/docs/hosts.md | ||
| if kind get clusters | grep -qx "${KIND_CLUSTER_NAME}"; then | ||
| echo "Kind cluster '${KIND_CLUSTER_NAME}' already exists; skipping create." | ||
| else | ||
| kind create cluster --name "${KIND_CLUSTER_NAME}" \ | ||
| --config hack/kind/cluster.yaml \ | ||
| --image="kindest/node:${KIND_IMAGE_VERSION}" | ||
| fi | ||
|
|
||
| echo "Adding registry config to nodes" | ||
| # 3. Add the registry config to the nodes | ||
| # | ||
| # This is necessary because localhost resolves to loopback addresses that are | ||
| # network-namespace local. | ||
| # In other words: localhost in the container is not localhost on the host. | ||
| # | ||
| # We want a consistent name that works from both ends, so we tell containerd to | ||
| # alias localhost:${reg_port} to the registry container when pulling images | ||
| REGISTRY_DIR="/etc/containerd/certs.d/localhost:${reg_port}" | ||
| for node in $(kind get nodes --name "${KIND_CLUSTER_NAME}"); do | ||
| docker exec "${node}" mkdir -p "${REGISTRY_DIR}" | ||
| cat <<EOF | docker exec -i "${node}" cp /dev/stdin "${REGISTRY_DIR}/hosts.toml" | ||
| [host."http://${reg_name}:5000"] | ||
| EOF | ||
| done | ||
|
|
||
| echo "Connecting registry to cluster network" | ||
| # 4. Connect the registry to the cluster network if not already connected | ||
| # This allows kind to bootstrap the network but ensures they're on the same network | ||
| if [ "$(docker inspect -f='{{json .NetworkSettings.Networks.kind}}' "${reg_name}")" = 'null' ]; then | ||
| docker network connect "kind" "${reg_name}" | ||
| fi | ||
|
|
||
| # 5. Document the local registry | ||
| # https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/generic/1755-communicating-a-local-registry | ||
| cat <<EOF | kubectl apply -f - | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| name: local-registry-hosting | ||
| namespace: kube-public | ||
| data: | ||
| localRegistryHosting.v1: | | ||
| host: "localhost:${reg_port}" | ||
| help: "https://kind.sigs.k8s.io/docs/user/local-registry/" | ||
| EOF |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.