feat: GatewayClass agentgateway-v2, controllerName agentgateway.dev/agentgateway #13088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... from kgateway.dev/agentgateway Controller agentgateway.dev/agentgateway works exactly like kgateway.dev/agentgateway, but has a new name. The recent GVK split inspires this. Signed-off-by: David L. Chandler <[email protected]>
chandler-solo
added
the
work in progress
chandler-solo
changed the title
The GVK split breaks Gateways using the old class, so it's time for a new class. Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
chandler-solo
changed the title
josh-pritchard
removed
the
work in progress
Contributor
Author
|
/retest |
Signed-off-by: Joshua Pritchard <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Signed-off-by: David L. Chandler <[email protected]>
Contributor
|
/retest |
Contributor
|
Not real failures |
Contributor
|
/retest |
lgadban
approved these changes
Dec 11, 2025
Comment on lines
+86
to
87
| // If the Gateway uses a GatewayClass with controllerName: agentgateway.dev/agentgateway, | ||
| // the EnvoyContainer values will be ignored. |
Contributor
There was a problem hiding this comment.
is this accurate now?
rather, I see that it's accurate, but is it relevant as an API doc going forward?
| // The agentgateway dataplane is automatically used when the Gateway references a GatewayClass | ||
| // with controllerName: kgateway.dev/agentgateway. | ||
| // with controllerName: agentgateway.dev/agentgateway. | ||
| type Agentgateway struct { |
Contributor
There was a problem hiding this comment.
breadcrumb for followup:
shouldn't this whole thing be removed now?
Contributor
There was a problem hiding this comment.
for posterity, these changes are all that is needed for the GwClass provisioner to work correctly with the new GwClass name/controllerName
Contributor
|
/retest |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A breaking change for agentgateway data plane users that:
Controller agentgateway.dev/agentgateway works exactly like kgateway.dev/agentgateway, but has a new name.
The recent GVK split of custom resources necessitates that old agentgateway Gateways be replaced with new Gateways that use controller
agentgateway.dev/agentgateway, and the most typical way to do that is by using the bundled GatewayClassagentgateway-v2Change Type
/kind breaking_change
Changelog
Additional Notes
This litters the GatewayClass
agentgatewaybecause it's not safe to delete it. You might have an older version of kgateway running side-by-side that still controls legacy agentgateway Gateways as you perform a blue/green deployment to modern Gateways that use GatewayClassagentgateway-v2. Consider deleting that GatewayClass yourself if you never used it or have stopped using it.