NUIDGenerator - refactor init to handle multithreading#4641
Merged
jlhughes merged 2 commits intodevelopmentfrom Nov 28, 2025
Merged
NUIDGenerator - refactor init to handle multithreading#4641jlhughes merged 2 commits intodevelopmentfrom
jlhughes merged 2 commits intodevelopmentfrom
Conversation
…ng is lazy and internal to the service, so not protected by normal CSpecFactory logic. Large DAOs can takes minutes to load and some UIDs are shared across DAOs resulting in muiltiple threads requesting 'next' and triggering init
lchanmann
approved these changes
Nov 28, 2025
jlhughes
commented
Nov 28, 2025
xuerongNanopay
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor init to handle multithreading.
The DAO loading is lazy and internal to the service, so not protected by normal CSpecFactory logic. Large DAOs can takes minutes to load and some UIDs are shared across DAOs resulting in multiple threads requesting 'next' and triggering init.