Skip to content

NUIDGenerator - refactor init to handle multithreading #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlhughes merged 2 commits into from
Nov 28, 2025
Merged

NUIDGenerator - refactor init to handle multithreading #4641

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c01b831
NUIDGenerator - refactor init to handle multithreading. The dao loadi…
jlhughes Nov 28, 2025
89b5397
Update src/foam/util/NUIDGenerator.js
jlhughes Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions src/foam/util/NUIDGenerator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ foam.CLASS({
}

AtomicLong seqNo_ = new AtomicLong();
AtomicBoolean initMaxSeqNo_ = new AtomicBoolean(false);
volatile AtomicBoolean initMaxSeqNo_ = new AtomicBoolean(false);
`,

properties: [
Expand Down Expand Up @@ -87,18 +87,25 @@ foam.CLASS({
{
name: 'initMaxSeqNo',
javaCode: `
if ( ! initMaxSeqNo_.getAndSet(true) ) {
Logger logger = Loggers.logger(getX(), this);
logger.info(getSalt(), "max", "find");
getDao().select(new AbstractSink() {
@Override
public void put(Object obj, Detachable sub) {
var id = (long) getPropertyInfo().get(obj);
maybeUpdateSeqNo(id);
}
});
Loggers.logger(getX(), this).info(getSalt(), "max", "found", seqNo_.get());
if ( ! initMaxSeqNo_.get() ) {
synchronized ( initMaxSeqNo_ ) {
if ( ! initMaxSeqNo_.get() ) {
Logger logger = Loggers.logger(getX(), this);
logger.info(getSalt(), "max", "find");
getDao().select(new AbstractSink() {
@Override
public void put(Object obj, Detachable sub) {
var id = (long) getPropertyInfo().get(obj);
maybeUpdateSeqNo(id);
}
public void eof() {
initMaxSeqNo_.getAndSet(true);
}
});
Loggers.logger(getX(), this).info(getSalt(), "max", "found", seqNo_.get());
}
}
}
`
},
{
Expand Down