fix: check conversation existence before accessing .title in generate_chat_title#1335
Open
Hariom9893 wants to merge 1 commit into
Open
fix: check conversation existence before accessing .title in generate_chat_title#1335Hariom9893 wants to merge 1 commit into
Hariom9893 wants to merge 1 commit into
Conversation
Author
|
Any update regarding the pull request , if it needs any changes please inform me so i can fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes an AttributeError crash in
generate_chat_title.Why
If
aget_conversation_by_userreturnsNone, the current code accessesconversation.titlebefore theNonecheck, raising an AttributeErrorbefore the 404 guard is ever reached.
Fix
Swapped the order of the two checks so
Noneis handled first.