Skip to content

fix: check conversation existence before accessing .title in generate_chat_title #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hariom9893 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

fix: check conversation existence before accessing .title in generate_chat_title #1335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/khoj/routers/api_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,21 +637,20 @@ async def generate_chat_title(
user: KhojUser = request.user.object
conversation = await ConversationAdapters.aget_conversation_by_user(user=user, conversation_id=conversation_id)

if not conversation:
raise HTTPException(status_code=404, detail="Conversation not found")

# Conversation.title is explicitly set by the user. Do not override.
if conversation.title:
return {"status": "ok", "title": conversation.title}

if not conversation:
raise HTTPException(status_code=404, detail="Conversation not found")

new_title = await acreate_title_from_history(request.user.object, conversation=conversation)
conversation.slug = clean_text_for_db(new_title[:200])

await conversation.asave()

return {"status": "ok", "title": new_title}


@api_chat.delete("/conversation/message", response_class=Response)
@requires(["authenticated"])
def delete_message(request: Request, delete_request: DeleteMessageRequestBody) -> Response:
Expand Down