Skip to content

Implement new behavior for Person content type - #228

Merged
davisagli merged 5 commits into
mainfrom
issue-134-person
Sep 10, 2025
Merged

Implement new behavior for Person content type#228
davisagli merged 5 commits into
mainfrom
issue-134-person

Conversation

@ericof

@ericof ericof commented Sep 9, 2025

Copy link
Copy Markdown
Contributor

https://gitlab.kitconcept.io/kitconcept/distribution-kitconcept-intranet/-/issues/134

  • Upgrade collective.person to version 1.0.0b1
    • Remove "required" restriction on "Bio" field
    • Remove "required" restriction on "Roles" field
  • Implement kitconcept.intranet.person behavior with the fields academic_title, job_title and department

@ericof
ericof requested a review from a team as a code owner September 9, 2025 16:57
Comment thread backend/src/kitconcept/intranet/profiles/default/types/Person.xml
Comment thread backend/src/kitconcept/intranet/profiles/default/types/Person.xml
Comment thread backend/src/kitconcept/intranet/upgrades/v20250909001/configure.zcml Outdated

@davisagli davisagli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericof Also, do we need to install the collective.person:catalog profile, or was that for some other use case?

@ericof

ericof commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

@ericof Also, do we need to install the collective.person:catalog profile, or was that for some other use case?

This is already taken care of by https://github.com/kitconcept/kitconcept-core/blob/main/backend/src/kitconcept/core/profiles/dependencies/catalog.xml

@ericof
ericof requested a review from davisagli September 9, 2025 23:17
if setup_tool.hasPendingUpgrades(profile_id):
setup_tool.upgradeProfile(profile_id)
current_version = setup_tool.getLastVersionForProfile(profile_id)
logger.info(f"Upgraded {profile_id} to version {current_version}")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: we should add this to https://6.docs.plone.org/plone.api/addon.html

@davisagli
davisagli merged commit 1978506 into main Sep 10, 2025
55 of 57 checks passed
@davisagli
davisagli deleted the issue-134-person branch September 10, 2025 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants