chore(ci): remove Go versions below 1.24 from CI matrix #15

kjanat · 2025-11-07T05:44:58Z

Remove CI test runs for Go 1.21.x, 1.22.x, and 1.23.x as the minimum supported version is 1.24.0 (as defined in go.mod).

This change:

Removes outdated Go versions from the test matrix
Aligns CI testing with the minimum supported version
Reduces CI execution time by removing unnecessary test runs
Maintains testing coverage for supported versions (1.24.x, 1.25.x)

Summary by CodeRabbit

Chores
- CI matrix narrowed to Go 1.24.x and 1.25.x; docker job now depends on fewer upstream jobs.
- Added/expanded pre-commit hooks including workflow linting and additional Go lint/format/verify hooks.
Tests
- Test step sets CGO_ENABLED=1 and improves test-result output and parsing for more reliable status reporting.
Style / Docs
- Minor formatting/whitespace cleanups and expanded documentation (including a Go 1.24/1.25 reference) across docs and scripts.

coderabbitai · 2025-11-07T05:45:08Z

Walkthrough

CI matrix reduced to Go 1.24.x and 1.25.x; Test step sets CGO_ENABLED=1 and tightens grep usage; test artifact writes use explicit echo statements; docker job now needs only test. Added/updated .pre-commit-config.yaml. Many files receive formatting/whitespace-only edits; no public API changes.

Changes

Cohort / File(s)	Change Summary
CI Workflows `\.github/workflows/ci.yml`, `\.github/workflows/autofix.yml`, `\.github/workflows/codeql.yml`	CI matrix trimmed to `1.24.x` and `1.25.x`; Test step sets `CGO_ENABLED: 1`; grep invocations tightened with `--`; test artifacts switched from heredoc to explicit `echo` outputs for `test-status`, `total-tests`, `passed-tests`, `failed-tests`; `docker` job `needs` reduced to only `test`; `golangci-lint` CLI call changed from `format` to `fmt`; CodeQL file reflowed/whitespace-only.
Pre-commit config (new/updated) `\.pre-commit-config.yaml`	Added local `actionlint` hook for GitHub workflows and expanded `golangci-lint` hooks: main hook runs `--new-from-rev HEAD --fix`, added `fmt` and config-verify hooks; additional pre-commit hooks listed for general repo hygiene.
Git metadata & ignore `\.github/CODEOWNERS`, `\.gitignore`	Fixed leading-space comment in `CODEOWNERS`; `.gitignore` reflowed/reordered/whitespace edits.
Docs & README `AGENTS.md`, `README.md`, `internal/exporters/output.md`, `\.github/CONTRIBUTING.md`, `\.github/CODE_OF_CONDUCT.md`, `\.github/SECURITY.md`, `DOCKER.md`, `\.github/PULL_REQUEST_TEMPLATE.md`	Formatting and reflow changes, added "Go 1.24 & 1.25" doc block in `AGENTS.md`, adjusted bullet/numbering styles and removed trailing spaces; PR template checkboxes toggled to checked.
Docker files `Dockerfile`, `Dockerfile.dev`, `DOCKER.md`	Trimmed trailing whitespace on `ARG TARGETPLATFORM`; `DOCKER.md` bolding/formatting changes only.
Taskfile `Taskfile.yml`	Converted dependency scalars to quoted strings (e.g., `deps: ['docker:build']`) — syntactic only.
Internal code (embed) `internal/exporters/html.go`	Updated embed directive to reference `html_template.gohtml` instead of `.html`; variable/signature unchanged.
Scripts `scripts/build.sh`, `scripts/build.ps1`	Whitespace/blank-line adjustments; no behavioral changes.
Miscellaneous various docs and small files	Minor whitespace/formatting edits across multiple repository files; no API or behavioral changes.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Dev as Developer (push)
    participant CI as GitHub Actions
    participant Test as test job
    participant Docker as docker job

    Dev->>CI: push/change
    CI->>Test: run tests (CGO_ENABLED=1, tightened grep, emit artifact vars via echo)
    alt tests pass
        Test-->>CI: success (test-status=passed)
        CI->>Docker: start docker job (needs: test)
        Docker-->>CI: docker job completes
    else tests fail
        Test-->>CI: failure (produce failure details)
    end
    Note right of CI: docker job no longer needs `docker-test` or `dependency-review`

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Pay extra attention to:
- \.github/workflows/ci.yml: verify CGO_ENABLED change, grep -- placements, and artifact echo outputs.
- \.pre-commit-config.yaml: ensure hook entries, file filters, and golangci-lint flags are correct.
- \.github/workflows/autofix.yml: confirm golangci-lint fmt CLI usage.
- internal/exporters/html.go: confirm embed filename change aligns with repository assets.

Poem

🐇
I trimmed the spaces, hopped to newer Go,
Set CGO to hum and let the tests show.
Echoed results, linted lines in time,
Docker waits now after tests pass fine.
A tiny rabbit dance — tidy, neat, and slow.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removal of Go versions below 1.24 from the CI matrix, which is the primary focus of the PR and is clearly reflected in the CI workflow modifications.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch claude/remove-ci-old-versions-011CUszbT9qVnsAnwmiFv4JC

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-11-07T05:45:59Z

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

Copilot

Pull Request Overview

This PR updates the CI workflow to streamline testing and fix workflow dependencies by testing against newer Go versions and correcting job dependency chains.

Reduced Go version matrix to test only with Go 1.24.x and 1.25.x
Fixed the docker job dependency chain to prevent impossible job prerequisites

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Remove CI test runs for Go 1.21.x, 1.22.x, and 1.23.x as the minimum supported version is 1.24.0 (as defined in go.mod). This change: - Removes outdated Go versions from the test matrix - Aligns CI testing with the minimum supported version - Reduces CI execution time by removing unnecessary test runs - Maintains testing coverage for supported versions (1.24.x, 1.25.x) fix(ci): remove impossible dependencies from docker job The docker job runs on push events to master/develop branches, but it was depending on docker-test and dependency-review jobs which only run on pull_request events. This created an impossible dependency chain that prevented the docker job from ever running. This change: - Removes docker-test and dependency-review from docker job dependencies - Keeps only the test job as a dependency (which runs on both events) - Allows docker build & push to run correctly on push events - Maintains PR-specific checks (docker-test, dependency-review) for PRs chore(tooling): add pre-commit configuration Introduces a `.pre-commit-config.yaml` file to automate code quality checks before commits. This configuration includes standard hooks for file hygiene (e.g., trailing whitespace, end-of-file fixes) and integrates `golangci-lint` to lint and format Go code on staged files. This helps enforce code style and catch issues early in the development process.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.pre-commit-config.yaml (1)

22-29: Consider clarifying the CI integration story.

The commented golangci-lint-full hook notes "Use this hook if you use pre-commit in CI," but the PR objectives focus on updating the CI workflow separately. Clarify whether this guidance should be active (enabled by default or per-environment config), documented in a README, or remains as-is for future reference. Given that the PR aligns CI with Go 1.24+, ensure any CI-specific configuration is coordinated.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43a76e0 and e7de5d0.

📒 Files selected for processing (2)

.github/workflows/ci.yml (1 hunks)
.pre-commit-config.yaml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/ci.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: CodeQL Analysis / Analyze (go)

🔇 Additional comments (3)

.pre-commit-config.yaml (3)

1-10: LGTM — Standard pre-commit hooks well-configured.

The basic hooks from pre-commit-hooks v6.0.0 provide good foundational checks for whitespace, file formatting, and commit hygiene.

14-21: golangci-lint v2.6.1 supports Go 1.24 as minimum version—configuration is correct.

golangci-lint v2.6.1 binaries are built with Go 1.24 and support Go 1.24 as minimum version. The hook configuration appropriately uses --new-from-rev HEAD --fix to lint only modified files with auto-fixes enabled. The require_serial: true setting prevents concurrent access issues, and pass_filenames: false correctly delegates file selection to the --new-from-rev flag.

Consider whether your team prefers auto-fixing behavior in pre-commit hooks (via --fix), as this silently modifies files before commit; some teams prefer error-only reporting at this stage and reserve fixes for CI.

30-44: Config file verified; no issues found.

The .golangci.yml file exists in the repository root and is properly configured for Go 1.24+. The go: "1.24" setting is explicitly set, all enabled linters are current (no deprecated ones), and the pre-commit hooks are correctly configured to detect and verify the config file via the regex pattern. The formatter and linter settings align well with modern Go standards. No action required.

Expands the pre-commit configuration with a wider range of hooks to enforce file quality, validation, security, and Git safety checks. The CI pipeline is updated to: - Correct the `golangci-lint` format command to `fmt`. - Enable CGO for test execution to support the race detector. - Improve the robustness of test report parsing scripts. Additionally, this commit includes minor stylistic and formatting cleanups across various project files.

Adds `actionlint` to the pre-commit configuration to validate GitHub Actions workflows. Significantly expands the `AGENTS.md` file with a comprehensive summary of new features and changes in Go 1.24 and 1.25, along with actionable recommendations for the project. Additionally, normalizes markdown list formatting across various documentation files for consistency.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (3)

.github/CODE_OF_CONDUCT.md (1)

32-32: Minor style suggestion: Strengthen wording on line 32.

The static analysis tool flagged line 32 ("Trolling, insulting or derogatory comments, and personal or political attacks") as a candidate for stronger wording. Consider whether a more direct or emphatic phrasing would better align with the tone of the Code of Conduct's enforcement messaging.
AGENTS.md (1)
67-427: Excellent Go 1.24 & 1.25 reference documentation! Consider fixing heading structure.

This is a valuable addition that provides comprehensive guidance on new features in Go 1.24 and 1.25, which aligns well with the PR's objective to update the minimum supported Go version to 1.24.0. The content is thorough and includes actionable recommendations for the project.

However, many subsections use bold emphasis (**Bold Text**) instead of proper markdown headings. This affects document navigation and accessibility.

Consider applying this pattern throughout the new section to use proper markdown headings:
-**Generic Type Aliases**
+#### Generic Type Aliases
The static analysis tool correctly identified this issue at multiple lines (77, 85, 92, 97, 101, 106, 111, 117, 128, 132, etc.). Using proper heading syntax (#### for level 4 headings) would improve:

Document structure and table of contents generation

Accessibility for screen readers

Markdown rendering consistency across different platforms
.github/workflows/ci.yml (1)
85-88: Improve consistency in grep usage across test result parsing.

Lines 86–88 use -- before patterns (e.g., grep -c -- "--- PASS:"), but line 85 omits it:
TOTAL_TESTS=$(grep -c "=== RUN" test-output.log || echo "0")
While "===" does not start with a hyphen, adding -- for consistency and robustness is safer:
-          TOTAL_TESTS=$(grep -c "=== RUN" test-output.log || echo "0")
+          TOTAL_TESTS=$(grep -c -- "=== RUN" test-output.log || echo "0")

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 073ab28 and a1a49a7.

📒 Files selected for processing (20)

.github/CODEOWNERS (1 hunks)
.github/CODE_OF_CONDUCT.md (1 hunks)
.github/CONTRIBUTING.md (4 hunks)
.github/PULL_REQUEST_TEMPLATE.md (1 hunks)
.github/SECURITY.md (1 hunks)
.github/workflows/autofix.yml (2 hunks)
.github/workflows/ci.yml (7 hunks)
.github/workflows/codeql.yml (1 hunks)
.gitignore (1 hunks)
.pre-commit-config.yaml (1 hunks)
AGENTS.md (2 hunks)
DOCKER.md (2 hunks)
Dockerfile (1 hunks)
Dockerfile.dev (1 hunks)
README.md (7 hunks)
Taskfile.yml (2 hunks)
internal/exporters/html.go (1 hunks)
internal/exporters/output.md (1 hunks)
scripts/build.ps1 (6 hunks)
scripts/build.sh (1 hunks)

✅ Files skipped from review due to trivial changes (3)

scripts/build.ps1
DOCKER.md
scripts/build.sh

🚧 Files skipped from review as they are similar to previous changes (7)

.gitignore
.pre-commit-config.yaml
Dockerfile.dev
internal/exporters/output.md
.github/workflows/codeql.yml
.github/workflows/autofix.yml
.github/CODEOWNERS

🧰 Additional context used

🪛 LanguageTool

.github/PULL_REQUEST_TEMPLATE.md

[style] ~13-~13: Consider using a different verb for a more formal wording.
Context: ... [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaki...

(FIX_RESOLVE)

.github/CODE_OF_CONDUCT.md

[style] ~32-~32: Try using a synonym here to strengthen your wording.
Context: ...ind - Trolling, insulting or derogatory comments, and personal or political attacks - Pu...

(COMMENT_REMARK)

.github/CONTRIBUTING.md

[grammar] ~36-~36: The verb “Create” needs to be in the to-infinitive form.
Context: ...n issues 7. Update documentation if needed 8. Create a pull request with a clear title and...

(MISSING_TO_BEFORE_A_VERB)

.github/SECURITY.md

[style] ~34-~34: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...e regular updates about our progress. - We will notify you when the vulnerability ...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

AGENTS.md

[uncategorized] ~42-~42: The preposition ‘to’ seems more likely in this position.
Context: ...k`) - Document error handling rationale in defer blocks when ignoring close errors...

(AI_HYDRA_LEO_REPLACE_IN_TO)

[uncategorized] ~147-~147: Loose punctuation mark.
Context: ...yptography Expansion** - crypto/mlkem: ML-KEM-768/1024 post-quantum key exchan...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~165-~165: Loose punctuation mark.
Context: ...ing Improvements** - testing.B.Loop(): Cleaner syntax replacing manual b.N i...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~165-~165: Possible missing comma found.
Context: ...ements** - testing.B.Loop(): Cleaner syntax replacing manual b.N iteration - Prev...

(AI_HYDRA_LEO_MISSING_COMMA)

[uncategorized] ~200-~200: Loose punctuation mark.
Context: ...cations & Removals - runtime.GOROOT(): Deprecated; use system path instead - `...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~232-~232: Loose punctuation mark.
Context: ...mmand Enhancements** - go build -asan: Now defaults to leak detection at progr...

(UNLIKELY_OPENING_PUNCTUATION)

[uncategorized] ~332-~332: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...r** on Apple M processors - AMD64 fused multiply-add instructions in v3+ mode - ⚠️ **Chang...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

README.md

[style] ~106-~106: Using many exclamation marks might seem excessive (in this case: 16 exclamation marks for a text that’s 8553 characters long)
Context: ...o, I don't know the version, but I have [![Go version](https://img.shields.io/gith...

(EN_EXCESSIVE_EXCLAMATION)

[uncategorized] ~392-~392: Possible missing comma found.
Context: ... with the standard Articulate Rise JSON format which includes: - Course metadata (tit...

(AI_HYDRA_LEO_MISSING_COMMA)

[uncategorized] ~397-~397: Possible missing preposition found.
Context: ...re - Content items with various types - Media references - Quiz/assessment data - Sty...

(AI_HYDRA_LEO_MISSING_OF)

🪛 markdownlint-cli2 (0.18.1)

AGENTS.md

77-77: Emphasis used instead of a heading