-
Notifications
You must be signed in to change notification settings - Fork 15
feat(KlaviyoCore): AuthTokenManager proactive refresh scheduling (MAGE-625) #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ab1470
wants to merge
1
commit into
ab/MAGE-624/authtokenmanager-dedup-and-timeouts
Choose a base branch
from
ab/MAGE-625/proactive-refresh-scheduling
base: ab/MAGE-624/authtokenmanager-dedup-and-timeouts
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| // | ||
| // OnceResolver.swift | ||
| // KlaviyoCore | ||
| // | ||
| // Created by Andrew Balmer on 2026-05-14. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| /// Serializes the first of two concurrent producers onto a | ||
| /// `CheckedContinuation` so that the loser's resume becomes a no-op. Used by | ||
| /// ``AuthTokenManager`` to race the in-flight fetch against a timeout without | ||
| /// leaning on `withThrowingTaskGroup` (which would block on the loser even | ||
| /// after the winner has resolved). | ||
| actor OnceResolver<T> { | ||
| private var resumed = false | ||
| private let continuation: CheckedContinuation<T, Error> | ||
|
|
||
| init(_ continuation: CheckedContinuation<T, Error>) { | ||
| self.continuation = continuation | ||
| } | ||
|
|
||
| /// - Returns: `true` if this call won the race and resumed the | ||
| /// continuation; `false` if the continuation was already resumed by an | ||
| /// earlier call. | ||
| @discardableResult | ||
| func resolve(_ result: Result<T, Error>) -> Bool { | ||
| guard !resumed else { return false } | ||
| resumed = true | ||
| switch result { | ||
| case let .success(value): continuation.resume(returning: value) | ||
| case let .failure(error): continuation.resume(throwing: error) | ||
| } | ||
| return true | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gentle pushback on the dual-path approach here. The iOS 15+
publisher.valuespath is idiomatic, but when wrapped insideAsyncStream { continuation in }it requires a nestedTask+onTerminationcancellation — which ends up being roughly the same complexity as thesinkfallback. There's no meaningful performance difference for a low-frequency lifecycle stream. Since iOS 13 support isn't going away soon and the two paths have to be maintained in parallel, it might be simpler to just use thesinkpath everywhere and delete the#availablebranch. Am I missing something that makes the 15+ path worth keeping?