Skip to content

API: checking name availabiliy for secrets and variables #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-v1.1.3
Choose a base branch
from

Conversation

nxtcoder19
Copy link
Contributor

@nxtcoder19 nxtcoder19 commented Dec 2, 2024

Summary by Sourcery

Implement name availability checking for secret variables and enhance the codebase to recognize 'secret_variable' as a resource type.

New Features:

  • Add functionality to check name availability for secret variables in the domain logic.

Enhancements:

  • Include 'secret_variable' as a recognized resource type in various parts of the codebase, including models and resource mappings.

Copy link

sourcery-ai bot commented Dec 2, 2024

Reviewer's Guide by Sourcery

This PR implements name availability checking functionality for secrets and variables by adding a new resource type 'secret_variable' and extending the CheckNameAvailability domain method to handle this new type.

Class diagram for ResourceType additions

classDiagram
    class ResourceType {
        <<enumeration>>
        +App
        +ClusterManagedService
        +Config
        +Environment
        +ExternalApp
        +ImagePullSecret
        +ImportedManagedResource
        +ManagedResource
        +Router
        +Secret
        +SecretVariable
        +ServiceBinding
    }
    note for ResourceType "Added SecretVariable to ResourceType enumeration"
Loading

File-Level Changes

Change Details Files
Added support for secret variable name availability checking
  • Added new case in CheckNameAvailability method to handle secret variable resource type
  • Implemented name checking using secretVariableRepo with account name and secret variable name filters
apps/console/internal/domain/names.go
Added new ResourceType for secret variables
  • Added ResourceTypeSecretVariable constant with value 'secret_variable'
  • Updated IsValid function to include the new resource type in validation
apps/console/internal/entities/resource-mapping.go
apps/console/internal/app/graph/model/models_gen.go
Cleaned up deprecated code
  • Removed commented out legacy code for secretVariableResolver and secretVariableInResolver
apps/console/internal/app/graph/secretvariable.resolvers.go

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nxtcoder19 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant