Skip to content

API: checking name availabiliy for secrets and variables #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-v1.1.3
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/console/internal/app/graph/generated/generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion apps/console/internal/app/graph/model/models_gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions apps/console/internal/app/graph/schema.graphqls
Original file line number Diff line number Diff line change
@@ -13,6 +13,7 @@ enum ConsoleResType {
environment
registry_image
vpn_device
secret_variable
}

type ConsoleCheckNameAvailabilityOutput @shareable {
31 changes: 0 additions & 31 deletions apps/console/internal/app/graph/secretvariable.resolvers.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
@@ -680,6 +680,7 @@ enum Github__com___kloudlite___api___apps___console___internal___entities__Resou
managed_resource
router
secret
secret_variable
service_binding
}

5 changes: 5 additions & 0 deletions apps/console/internal/domain/names.go
Original file line number Diff line number Diff line change
@@ -58,6 +58,11 @@ func (d *domain) CheckNameAvailability(ctx context.Context, accountName string,
return checkResourceName(ctx, repos.Filter{fields.AccountName: accountName, fields.MetadataName: name, fc.ManagedResourceManagedServiceName: msvcName}, d.mresRepo)
}

case entities.ResourceTypeSecretVariable:
{
return checkResourceName(ctx, repos.Filter{fields.AccountName: accountName, fc.SecretVariableName: name}, d.secretVariableRepo)
}

default:
{
if environmentName == nil {
1 change: 1 addition & 0 deletions apps/console/internal/entities/resource-mapping.go
Original file line number Diff line number Diff line change
@@ -20,6 +20,7 @@ const (
ResourceTypeImportedManagedResource ResourceType = "imported_managed_resource"
ResourceTypeClusterManagedService ResourceType = "cluster_managed_service"
ResourceTypeServiceBinding ResourceType = "service_binding"
ResourceTypeSecretVariable ResourceType = "secret_variable"
)

type ResourceHeirarchy string