Conversation
Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
There was a problem hiding this comment.
Summary of Changes
Hello @YaoZengzeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request applies cargo fmt to several example files within the orion-xds directory. The changes are purely cosmetic, reformatting the tracing_subscriber initialization calls to adhere to standard Rust formatting conventions. This ensures code consistency and improves readability across these example files.
Highlights
- Code Formatting: Applied
cargo fmttoorion-xds/examples/client.rs,orion-xds/examples/server.rs,orion-xds/examples/server_routes_and_loads.rs, andorion-xds/examples/server_secret_rotation.rs. - Readability Improvement: The
tracing_subscriber::fmt().with_env_filter(...)calls are now formatted on a single line, improving code consistency and readability.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request applies formatting changes across several example files. While the title suggests a cargo fmt fix, the changes actually consolidate method chains into single long lines, which reduces readability and goes against standard Rust formatting conventions. For better maintainability and adherence to community standards, I've suggested reverting these changes in each file to the more readable multi-line format.
| EnvFilter::try_from_default_env() | ||
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | ||
| ) | ||
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) |
There was a problem hiding this comment.
Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with rustfmt standards and improve maintainability.
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) | |
| .with_env_filter( | |
| EnvFilter::try_from_default_env() | |
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | |
| ) |
| EnvFilter::try_from_default_env() | ||
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | ||
| ) | ||
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) |
There was a problem hiding this comment.
Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with rustfmt standards and improve maintainability.
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) | |
| .with_env_filter( | |
| EnvFilter::try_from_default_env() | |
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | |
| ) |
| EnvFilter::try_from_default_env() | ||
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | ||
| ) | ||
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) |
There was a problem hiding this comment.
Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with rustfmt standards and improve maintainability.
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) | |
| .with_env_filter( | |
| EnvFilter::try_from_default_env() | |
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | |
| ) |
| EnvFilter::try_from_default_env() | ||
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | ||
| ) | ||
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) |
There was a problem hiding this comment.
Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with rustfmt standards and improve maintainability.
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) | |
| .with_env_filter( | |
| EnvFilter::try_from_default_env() | |
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | |
| ) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dawid-nowak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Still failure |
|
@YaoZengzeng @hzxuzhonghu should i raise pr for same ? i can try to fix it |
|
@Eeshu-Yadav of course 🚀 |
|
closed, fixed by #40 |
No description provided.