-
Notifications
You must be signed in to change notification settings - Fork 22
fix cargo fmt #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cargo fmt #34
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -8,10 +8,7 @@ use tracing_subscriber::EnvFilter; | |||||||||||
| #[tokio::main] | ||||||||||||
| async fn main() -> Result<(), Box<dyn std::error::Error>> { | ||||||||||||
| tracing_subscriber::fmt() | ||||||||||||
| .with_env_filter( | ||||||||||||
| EnvFilter::try_from_default_env() | ||||||||||||
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | ||||||||||||
| ) | ||||||||||||
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with
Suggested change
|
||||||||||||
| .init(); | ||||||||||||
|
|
||||||||||||
| let (delta_resource_tx, delta_resources_rx) = tokio::sync::mpsc::channel(100); | ||||||||||||
|
|
||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -10,10 +10,7 @@ use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt, EnvFilte | |||||||||||
| #[tokio::main] | ||||||||||||
| async fn main() -> Result<(), Box<dyn std::error::Error>> { | ||||||||||||
| tracing_subscriber::fmt() | ||||||||||||
| .with_env_filter( | ||||||||||||
| EnvFilter::try_from_default_env() | ||||||||||||
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | ||||||||||||
| ) | ||||||||||||
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with
Suggested change
|
||||||||||||
| .init(); | ||||||||||||
|
|
||||||||||||
| let (delta_resource_tx, delta_resources_rx) = tokio::sync::mpsc::channel(100); | ||||||||||||
|
|
||||||||||||
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -14,10 +14,7 @@ use tracing_subscriber::{layer::SubscriberExt, util::SubscriberInitExt, EnvFilte | |||||||||||
| #[tokio::main] | ||||||||||||
| async fn main() -> Result<(), Box<dyn std::error::Error>> { | ||||||||||||
| tracing_subscriber::fmt() | ||||||||||||
| .with_env_filter( | ||||||||||||
| EnvFilter::try_from_default_env() | ||||||||||||
| .unwrap_or_else(|_| "info,orion_xds=debug".into()), | ||||||||||||
| ) | ||||||||||||
| .with_env_filter(EnvFilter::try_from_default_env().unwrap_or_else(|_| "info,orion_xds=debug".into())) | ||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with
Suggested change
|
||||||||||||
| .init(); | ||||||||||||
|
|
||||||||||||
| let (delta_resource_tx, delta_resources_rx) = tokio::sync::mpsc::channel(100); | ||||||||||||
|
|
||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collapsing this method chain into a single line makes it harder to read and exceeds the typical line length limit for Rust code. Reverting to the previous multi-line format would be more consistent with
rustfmtstandards and improve maintainability.