Skip to content

UIEXT-3407: Improved parameter description and info message (Feature …#186

Open
mgohm wants to merge 1 commit intomasterfrom
todo/UIEXT-3407-WebUI-Migration-Feature-Selection-Filter
Open

UIEXT-3407: Improved parameter description and info message (Feature …#186
mgohm wants to merge 1 commit intomasterfrom
todo/UIEXT-3407-WebUI-Migration-Feature-Selection-Filter

Conversation

@mgohm
Copy link
Copy Markdown
Contributor

@mgohm mgohm commented Apr 12, 2026

…Selection Filter)

UIEXT-3407 (WebUI-Migration Feature Selection Filter)

Copilot AI review requested due to automatic review settings April 12, 2026 12:40
@mgohm mgohm requested a review from a team as a code owner April 12, 2026 12:40
@mgohm mgohm requested a review from knime-ghub-bot April 12, 2026 12:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Feature Selection Filter node’s dialog wording to better reflect that users select feature sets and improves the optimization info message.

Changes:

  • Renamed UI titles/labels from “Feature selection/Features” to “Feature set selection/Manual” for clearer intent.
  • Updated the optimization info message to include the score name and whether it is minimized/maximized.
  • Refreshed WebUI snapshot tests to match the updated UI schema output.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
org.knime.base/src/org/knime/base/node/meta/feature/selection/FeatureSelectionFilterNodeParameters.java Adjusts widget titles/labels and refines the optimization info message text.
org.knime.base.tests/files/test_snapshots/org.knime.base.node.meta.feature.selection.FeatureSelectionFilterNodeParametersTest1.snap Updates expected snapshot output for the renamed titles/labels.
org.knime.base.tests/files/test_snapshots/org.knime.base.node.meta.feature.selection.FeatureSelectionFilterNodeParametersTest.snap Updates expected snapshot output for the renamed titles/labels.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…Selection Filter)

UIEXT-3407 (WebUI-Migration Feature Selection Filter)
@mgohm mgohm force-pushed the todo/UIEXT-3407-WebUI-Migration-Feature-Selection-Filter branch from e4fd949 to 573bdd3 Compare April 17, 2026 14:18
@sonarqubecloud
Copy link
Copy Markdown

@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants