Skip to content

UIEXT-3407: Improved parameter description and info message (Feature … #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgohm wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UIEXT-3407: Improved parameter description and info message (Feature … #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .../org.knime.base.node.meta.feature.selection.FeatureSelectionFilterNodeParametersTest.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
},
"manualSelection" : {
"type" : "string",
"title" : "Select by feature set",
"title" : "Select a feature set",
"description" : "Select the feature set based on the score and number of features.\n"
},
"optimizationInfo" : {
Expand All @@ -84,16 +84,16 @@
"selectionMode" : {
"oneOf" : [ {
"const" : "NUMBER_OF_FEATURES",
"title" : "Features"
"title" : "Manual"
}, {
"const" : "BEST_SCORE",
"title" : "Best score"
}, {
"const" : "THRESHOLD",
"title" : "Threshold"
} ],
"title" : "Feature selection mode",
"description" : "Choose how the features are selected from the available feature sets computed during the feature selection\nloop.\n\n<ul>\n<li><b>Features</b>: Choose a set of features to include.\n</li>\n<li><b>Best score</b>: The feature set with the best prediction score is chosen. If the score is being maximized, the best\nscore is the highest score value; if the score is being minimized, the best score is the lowest\nscore value.\n</li>\n<li><b>Threshold</b>: Set a prediction score threshold. The smallest feature set whose score meets the threshold requirement\nis selected: below the threshold if the score is minimized, above the threshold if the score is\nmaximized.\n</li>\n</ul>",
"title" : "Feature set selection mode",
"description" : "Choose how the features are selected from the available feature sets computed during the feature selection\nloop.\n\n<ul>\n<li><b>Manual</b>: Choose a set of features to include.\n</li>\n<li><b>Best score</b>: The feature set with the best prediction score is chosen. If the score is being maximized, the best\nscore is the highest score value; if the score is being minimized, the best score is the lowest\nscore value.\n</li>\n<li><b>Threshold</b>: Set a prediction score threshold. The smallest feature set whose score meets the threshold requirement\nis selected: below the threshold if the score is minimized, above the threshold if the score is\nmaximized.\n</li>\n</ul>",
"default" : "NUMBER_OF_FEATURES"
}
}
Expand Down
8 changes: 4 additions & 4 deletions ...org.knime.base.node.meta.feature.selection.FeatureSelectionFilterNodeParametersTest1.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
},
"manualSelection" : {
"type" : "string",
"title" : "Select by feature set",
"title" : "Select a feature set",
"description" : "Select the feature set based on the score and number of features.\n"
},
"optimizationInfo" : {
Expand All @@ -84,16 +84,16 @@
"selectionMode" : {
"oneOf" : [ {
"const" : "NUMBER_OF_FEATURES",
"title" : "Features"
"title" : "Manual"
}, {
"const" : "BEST_SCORE",
"title" : "Best score"
}, {
"const" : "THRESHOLD",
"title" : "Threshold"
} ],
"title" : "Feature selection mode",
"description" : "Choose how the features are selected from the available feature sets computed during the feature selection\nloop.\n\n<ul>\n<li><b>Features</b>: Choose a set of features to include.\n</li>\n<li><b>Best score</b>: The feature set with the best prediction score is chosen. If the score is being maximized, the best\nscore is the highest score value; if the score is being minimized, the best score is the lowest\nscore value.\n</li>\n<li><b>Threshold</b>: Set a prediction score threshold. The smallest feature set whose score meets the threshold requirement\nis selected: below the threshold if the score is minimized, above the threshold if the score is\nmaximized.\n</li>\n</ul>",
"title" : "Feature set selection mode",
"description" : "Choose how the features are selected from the available feature sets computed during the feature selection\nloop.\n\n<ul>\n<li><b>Manual</b>: Choose a set of features to include.\n</li>\n<li><b>Best score</b>: The feature set with the best prediction score is chosen. If the score is being maximized, the best\nscore is the highest score value; if the score is being minimized, the best score is the lowest\nscore value.\n</li>\n<li><b>Threshold</b>: Set a prediction score threshold. The smallest feature set whose score meets the threshold requirement\nis selected: below the threshold if the score is minimized, above the threshold if the score is\nmaximized.\n</li>\n</ul>",
"default" : "NUMBER_OF_FEATURES"
}
}
Expand Down
10 changes: 5 additions & 5 deletions .../src/org/knime/base/node/meta/feature/selection/FeatureSelectionFilterNodeParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ class FeatureSelectionFilterNodeParameters implements NodeParameters {
@TextMessage(OptimizationInfoProvider.class)
Void m_optimizationInfo;

@Widget(title = "Feature selection mode", description = """
@Widget(title = "Feature set selection mode", description = """
Choose how the features are selected from the available feature sets computed during the feature selection
loop.
""")
Expand All @@ -120,7 +120,7 @@ interface SelectionModeRef extends ParameterReference<SelectionMode> {
}

@Persistor(DoNotPersistString.class)
@Widget(title = "Select by feature set", description = """
@Widget(title = "Select a feature set", description = """
Select the feature set based on the score and number of features.
""")
@ChoicesProvider(ManualSelectionChoicesProvider.class)
Expand Down Expand Up @@ -329,8 +329,8 @@ public Optional<TextMessage.Message> computeState(final NodeParametersInput para
}
final var featureSelectionModel = featureSelectionModelOpt.get();
return Optional.of(new TextMessage.Message("Optimization Criterion",
featureSelectionModel.isMinimize() ?
"The score is being minimized." : "The score is being maximized.",
"The score (%s) is being %s.".formatted(featureSelectionModel.getScoreName(),
featureSelectionModel.isMinimize() ? "minimized" : "maximized"),
TextMessage.MessageType.INFO));
}

Expand Down Expand Up @@ -622,7 +622,7 @@ private static Optional<FeatureSelectionModel> getFeatureSelectionModel(final No

enum SelectionMode {

@Label(value = "Features", description = """
@Label(value = "Manual", description = """
Choose a set of features to include.
""")
NUMBER_OF_FEATURES, //
Expand Down