UIEXT-3554: Split legacy API from EffectPredicateProvider

[PaulBrnrther]

UIEXT-3554 (Use an extension point for enhancing the EffectPredicateProvider (and rewrite the one for LegacyMultiFileSelection))

[Copilot]

Pull request overview

Updates several node-parameter classes to use the new extension-point based legacy predicate initializers instead of casting the PredicateInitializer to the legacy API, aligning with UIEXT-3554’s goal of splitting legacy API usage from EffectPredicateProvider.

Changes:

• Replace ((LegacyPredicateInitializer)i)... calls with i.getRegisteredPredicateInitializer(...).getLegacy... in effect predicate providers.
• Update imports to reference the new legacy predicate initializer types (LegacyMultiFileSelectionPredicateInitializer, LegacyFileWriterPredicateInitializer).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
.../TransferFilesFileChooserNodeParameters.java	Switches legacy multi-file selection predicate init to registered initializer API.
.../CompressFileChooserNodeParameters.java	Switches legacy multi-file selection predicate init to registered initializer API.
.../LineReaderNodeParameters.java	Switches legacy multi-file selection predicate init to registered initializer API.
.../CSVWriter2NodeParameters.java	Switches legacy file-writer predicate init to registered initializer API.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The new LegacyMultiFileSelectionPredicateInitializer import is separated from the other legacy widget imports (lines 81–82). Please keep org.knime.node.parameters.legacy.widget.file.* imports grouped together for consistent import organization.

[Copilot]

Consider moving the new LegacyMultiFileSelectionPredicateInitializer import next to the other legacy widget imports (e.g. LegacyMultiFileSelection at line 86) to preserve the existing import grouping in this file.

[Copilot]

The LegacyFileWriterPredicateInitializer import is currently placed after the updates.* imports, while other legacy widget imports are grouped at lines 76–77. Please move it alongside the other org.knime.node.parameters.legacy.widget.file.* imports to keep import grouping consistent.

[Copilot]

The new LegacyMultiFileSelectionPredicateInitializer import breaks the existing grouping of legacy widget imports (currently grouped at lines 68–70). Please move this import alongside the other org.knime.node.parameters.legacy.widget.file.* imports to keep the import organization consistent in this file.

[Copilot]

The continuation indentation of this fluent call chain is inconsistent (the chained lines are indented more than the surrounding style used in similar classes, e.g. CompressFileChooserNodeParameters). Please reformat to match the project's typical method-chaining indentation for readability.

Suggested change

	.getLegacyMultiFileSelection(SourceFileChooserRef.class).getSelectionMode()
	.isOneOf(MultiFileSelectionMode.FOLDER);
	.getLegacyMultiFileSelection(SourceFileChooserRef.class).getSelectionMode()
	.isOneOf(MultiFileSelectionMode.FOLDER);

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud