Skip to content

UIEXT-3554: Split legacy API from EffectPredicateProvider #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulBrnrther wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UIEXT-3554: Split legacy API from EffectPredicateProvider #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ime.base/src/org/knime/base/node/io/filehandling/csv/writer/CSVWriter2NodeParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
import org.knime.node.parameters.updates.StateProvider;
import org.knime.node.parameters.updates.ValueProvider;
import org.knime.node.parameters.updates.ValueReference;
import org.knime.node.parameters.updates.legacy.LegacyPredicateInitializer;
import org.knime.node.parameters.legacy.widget.file.LegacyFileWriterPredicateInitializer;
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The LegacyFileWriterPredicateInitializer import is currently placed after the updates.* imports, while other legacy widget imports are grouped at lines 76–77. Please move it alongside the other org.knime.node.parameters.legacy.widget.file.* imports to keep import grouping consistent.

Copilot uses AI. Check for mistakes.
import org.knime.node.parameters.widget.choices.ValueSwitchWidget;
import org.knime.node.parameters.widget.text.TextAreaWidget;
import org.knime.node.parameters.widget.text.TextInputWidget;
Expand Down Expand Up @@ -377,8 +377,9 @@ private static final class OverwritePolicyIsAppend implements EffectPredicatePro

@Override
public EffectPredicate init(final PredicateInitializer i) {
return ((LegacyPredicateInitializer)i).getLegacyFileWriter(OutputFileRef.class) //
.getOverwritePolicy().isOneOf(OverwritePolicy.append);
return i.getRegisteredPredicateInitializer(LegacyFileWriterPredicateInitializer.class)
.getLegacyFileWriter(OutputFileRef.class).getOverwritePolicy()
.isOneOf(OverwritePolicy.append);
}
}

Expand Down
7 changes: 4 additions & 3 deletions ...ime.base/src/org/knime/base/node/io/filehandling/linereader/LineReaderNodeParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@
import org.knime.node.parameters.updates.EffectPredicateProvider;
import org.knime.node.parameters.updates.ParameterReference;
import org.knime.node.parameters.updates.ValueReference;
import org.knime.node.parameters.updates.legacy.LegacyPredicateInitializer;
import org.knime.node.parameters.legacy.widget.file.LegacyMultiFileSelectionPredicateInitializer;
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving the new LegacyMultiFileSelectionPredicateInitializer import next to the other legacy widget imports (e.g. LegacyMultiFileSelection at line 86) to preserve the existing import grouping in this file.

Copilot uses AI. Check for mistakes.
import org.knime.node.parameters.widget.OptionalWidget;
import org.knime.node.parameters.widget.OptionalWidget.DefaultValueProvider;
import org.knime.node.parameters.widget.choices.Label;
Expand Down Expand Up @@ -163,8 +163,9 @@ public FileEncodingPersistor() {
private static final class MultiFileSelectionIsActive implements EffectPredicateProvider {
@Override
public EffectPredicate init(final PredicateInitializer i) {
return ((LegacyPredicateInitializer)i).getLegacyMultiFileSelection(FileSelectionRef.class)
.getSelectionMode().isOneOf(MultiFileSelectionMode.FILES_IN_FOLDERS, MultiFileSelectionMode.FOLDER);
return i.getRegisteredPredicateInitializer(LegacyMultiFileSelectionPredicateInitializer.class)
.getLegacyMultiFileSelection(FileSelectionRef.class).getSelectionMode()
.isOneOf(MultiFileSelectionMode.FILES_IN_FOLDERS, MultiFileSelectionMode.FOLDER);
}
}

Expand Down
7 changes: 4 additions & 3 deletions ...me/filehandling/utility/nodes/compress/filechooser/CompressFileChooserNodeParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
import org.knime.node.parameters.updates.ParameterReference;
import org.knime.node.parameters.updates.ValueProvider;
import org.knime.node.parameters.updates.ValueReference;
import org.knime.node.parameters.updates.legacy.LegacyPredicateInitializer;
import org.knime.node.parameters.legacy.widget.file.LegacyMultiFileSelectionPredicateInitializer;
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new LegacyMultiFileSelectionPredicateInitializer import is separated from the other legacy widget imports (lines 81–82). Please keep org.knime.node.parameters.legacy.widget.file.* imports grouped together for consistent import organization.

Copilot uses AI. Check for mistakes.
import org.knime.node.parameters.widget.choices.Label;
import org.knime.node.parameters.widget.choices.ValueSwitchWidget;
import org.knime.node.parameters.widget.text.TextInputWidget;
Expand Down Expand Up @@ -310,8 +310,9 @@ public EffectPredicate init(final PredicateInitializer i) {
private static final class SourceFilterModeIsFolder implements EffectPredicateProvider {
@Override
public EffectPredicate init(final PredicateInitializer i) {
return ((LegacyPredicateInitializer)i).getLegacyMultiFileSelection(SourceFileChooserRef.class)
.getSelectionMode().isOneOf(MultiFileSelectionMode.FOLDER);
return i.getRegisteredPredicateInitializer(LegacyMultiFileSelectionPredicateInitializer.class)
.getLegacyMultiFileSelection(SourceFileChooserRef.class).getSelectionMode()
.isOneOf(MultiFileSelectionMode.FOLDER);
}
}

Expand Down
7 changes: 4 additions & 3 deletions ...lehandling/utility/nodes/transfer/filechooser/TransferFilesFileChooserNodeParameters.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
import org.knime.node.parameters.updates.EffectPredicateProvider;
import org.knime.node.parameters.updates.ParameterReference;
import org.knime.node.parameters.updates.ValueReference;
import org.knime.node.parameters.updates.legacy.LegacyPredicateInitializer;
import org.knime.node.parameters.legacy.widget.file.LegacyMultiFileSelectionPredicateInitializer;
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new LegacyMultiFileSelectionPredicateInitializer import breaks the existing grouping of legacy widget imports (currently grouped at lines 68–70). Please move this import alongside the other org.knime.node.parameters.legacy.widget.file.* imports to keep the import organization consistent in this file.

Copilot uses AI. Check for mistakes.
import org.knime.node.parameters.updates.util.BooleanReference;
import org.knime.node.parameters.widget.choices.Label;
import org.knime.node.parameters.widget.choices.ValueSwitchWidget;
Expand Down Expand Up @@ -120,8 +120,9 @@ private interface Output {
private static final class SourceFilterModeIsFolder implements EffectPredicateProvider {
@Override
public EffectPredicate init(final PredicateInitializer i) {
return ((LegacyPredicateInitializer)i).getLegacyMultiFileSelection(SourceFileChooserRef.class)
.getSelectionMode().isOneOf(MultiFileSelectionMode.FOLDER);
return i.getRegisteredPredicateInitializer(LegacyMultiFileSelectionPredicateInitializer.class)
.getLegacyMultiFileSelection(SourceFileChooserRef.class).getSelectionMode()
.isOneOf(MultiFileSelectionMode.FOLDER);
Comment on lines +124 to +125
Copy link

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The continuation indentation of this fluent call chain is inconsistent (the chained lines are indented more than the surrounding style used in similar classes, e.g. CompressFileChooserNodeParameters). Please reformat to match the project's typical method-chaining indentation for readability.

Suggested change
.getLegacyMultiFileSelection(SourceFileChooserRef.class).getSelectionMode()
.isOneOf(MultiFileSelectionMode.FOLDER);
.getLegacyMultiFileSelection(SourceFileChooserRef.class).getSelectionMode()
.isOneOf(MultiFileSelectionMode.FOLDER);

Copilot uses AI. Check for mistakes.
}
}

Expand Down