feat(KNO-10034): create .knockbranch file when it does not exist #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mattmikolay
changed the title
mattmikolay
requested review from
cjbell,
connorlindsey,
meryldakin and
thomaswhyyou
connorlindsey
approved these changes
Oct 10, 2025
| * | ||
| * @returns the path to the project root directory | ||
| */ | ||
| export const findProjectRoot = async (): Promise<string> => { |
There was a problem hiding this comment.
I'm curious on the heuristic of looking for the .gitignore. I think it makes sense for when you're in your project and executing a command from a sub-folder but I wonder if it may have unintended consequences, or if we should place other limits, like only looking up N levels. Just feels like an early optimization but I'm not completely opposed to it.
There was a problem hiding this comment.
Good point. I just updated findProjectRoot to add an additional restriction: we’ll stop searching for .gitignore when we find a .git directory, since that is most likely the repository root.
mattmikolay
force-pushed
the
mattmik-kno-10048-cli-add-branch-exit-command
branch
from
0feff27 to
6ccacee
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
from
de49ee1 to
2363bcd
Compare
mattmikolay
changed the title
mattmikolay
force-pushed
the
mattmik-kno-10048-cli-add-branch-exit-command
branch
from
6ccacee to
f04186a
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
2 times, most recently
from
4249415 to
54053d6
Compare
mattmikolay
force-pushed
the
mattmik-kno-10048-cli-add-branch-exit-command
branch
2 times, most recently
from
2575171 to
b349bb1
Compare
mattmikolay
changed the base branch from
mattmik-kno-10048-cli-add-branch-exit-command
to
graphite-base/624
mattmikolay
force-pushed
the
graphite-base/624
branch
from
d7b680e to
802bd75
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
from
54053d6 to
458225d
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
from
458225d to
506c585
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
from
506c585 to
811cb3b
Compare
Merge activity
|
mattmikolay
deleted the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
knock branch switchcommand so that when a.knock_branchfile is not found, we prompt the user to create one automatically. We’ll look for an existing.gitignorefile and create the.knock_branchfile sibling to it. The directory containing.gitignoreis our best guess for the root of the user’s project.I also updated
knock branch exitso that instead of deleting the.knock_branchfile, it writes an empty string to it. This feels less intrusive than constantly deleting and re-creating.knock_branch.Tasks
KNO-10034
Loom demo
https://www.loom.com/share/aaa825700da144ab8f6ea08208870860?sid=455ace12-9bf9-4d68-8137-93a0c4f388fa