feat(KNO-10035): prompt to add .knockbranch to .gitignore #625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 10, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mattmikolay
changed the title
mattmikolay
changed the title
mattmikolay
changed the title
mattmikolay
commented
Oct 10, 2025
| ); | ||
| }); | ||
|
|
||
| describe("and ancestor directory contains a .gitignore file", () => { |
There was a problem hiding this comment.
I failed to find a way to use Sinon to mock the isFileIgnoredByGit function so that it returns true. That’s why there’s no test case here for when the .gitignore file already exists and already ignores .knock_branch.
mattmikolay
requested review from
cjbell,
connorlindsey,
meryldakin and
thomaswhyyou
mattmikolay
force-pushed
the
mattmik-kno-10035-cli-automatically-update-gitignore-to-ignore-knock_branch
branch
from
314724d to
23f1e80
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
from
de49ee1 to
2363bcd
Compare
mattmikolay
changed the title
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
from
2363bcd to
4249415
Compare
mattmikolay
force-pushed
the
mattmik-kno-10035-cli-automatically-update-gitignore-to-ignore-knock_branch
branch
from
23f1e80 to
185e03b
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
from
4249415 to
54053d6
Compare
mattmikolay
force-pushed
the
mattmik-kno-10035-cli-automatically-update-gitignore-to-ignore-knock_branch
branch
from
185e03b to
2b364eb
Compare
mattmikolay
force-pushed
the
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
branch
3 times, most recently
from
506c585 to
811cb3b
Compare
mattmikolay
force-pushed
the
mattmik-kno-10035-cli-automatically-update-gitignore-to-ignore-knock_branch
branch
from
2b364eb to
7a22fa1
Compare
mattmikolay
changed the base branch from
mattmik-kno-10034-cli-create-knock_branch-file-when-it-does-not-exist
to
graphite-base/625
mattmikolay
force-pushed
the
graphite-base/625
branch
from
811cb3b to
dc9244a
Compare
mattmikolay
force-pushed
the
mattmik-kno-10035-cli-automatically-update-gitignore-to-ignore-knock_branch
branch
from
7a22fa1 to
5bf6934
Compare
mattmikolay
force-pushed
the
mattmik-kno-10035-cli-automatically-update-gitignore-to-ignore-knock_branch
branch
from
5bf6934 to
49abde5
Compare
connorlindsey
approved these changes
Oct 13, 2025
Merge activity
|
mattmikolay
deleted the
mattmik-kno-10035-cli-automatically-update-gitignore-to-ignore-knock_branch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
knock branch switchcommand so that when a.knock_branchfile does not yet exist, and after the user chooses to create a new.knock_branchfile in the project directory, we automatically create or update.gitignoreto ignore.knock_branch.Tasks
KNO-10035
Loom demo
https://www.loom.com/share/8089e496fa564ad9b818e736466a4a7c