fix: call res.end() when socket is not writable to prevent HTTP/2 HEAD hang#1947
Open
guoyangzhen wants to merge 2 commits intokoajs:v2.xfrom
Open
fix: call res.end() when socket is not writable to prevent HTTP/2 HEAD hang#1947guoyangzhen wants to merge 2 commits intokoajs:v2.xfrom
guoyangzhen wants to merge 2 commits intokoajs:v2.xfrom
Conversation
…D hang When ctx.writable is false (common with HTTP/2), the respond function returned early without calling res.end(), causing HEAD requests to hang indefinitely. This restores the behavior from v2.16.0 which was accidentally dropped in v2.16.1. Fixes koajs#1547
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
ctx.writableisfalse(common with HTTP/2), therespondfunction returns early without callingres.end(), causing HEAD requests to hang indefinitely.This was working in v2.16.0 but was accidentally dropped in v2.16.1 (the
res.end()call was removed from the early return). Multiple users reported the regression (#1547).Change
The master branch already has this fix. This backports it to v2.x.
Related
Fixes #1547