Skip to content

fix: call res.end() when socket is not writable to prevent HTTP/2 HEAD hang #1947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guoyangzhen wants to merge 2 commits into
base: v2.x
Choose a base branch
from
Open

fix: call res.end() when socket is not writable to prevent HTTP/2 HEAD hang #1947

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acc67e7
fix: call res.end() when socket is not writable to prevent HTTP/2 HEA…
guoyangzhen Apr 1, 2026
9826b77
fix: lint errors - use ctx.res before declaration and add trailing ne…
guoyangzhen Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ function respond(ctx) {
// allow bypassing koa
if (false === ctx.respond) return;

if (!ctx.writable) return;
if (!ctx.writable) return ctx.res.end();

const res = ctx.res;
let body = ctx.body;
Expand All @@ -267,23 +267,23 @@ function respond(ctx) {
if (statuses.empty[code]) {
// strip headers
ctx.body = null;
return res.end();
return ctx.res.end();
}

if ('HEAD' === ctx.method) {
if (!res.headersSent && !ctx.response.has('Content-Length')) {
const { length } = ctx.response;
if (Number.isInteger(length)) ctx.length = length;
}
return res.end();
return ctx.res.end();
}

// status body
if (null == body) {
if (ctx.response._explicitNullBody) {
ctx.response.remove('Content-Type');
ctx.response.remove('Transfer-Encoding');
return res.end();
return ctx.res.end();
}
if (ctx.req.httpVersionMajor >= 2) {
body = String(code);
Expand Down
Loading