Skip to content

Conversation

@palfrey
Copy link
Contributor

@palfrey palfrey commented Jul 19, 2025

No description provided.

@palfrey palfrey mentioned this pull request Jul 19, 2025
Copy link
Owner

@koiuo koiuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @palfrey

Thanks a lot for the fix.

WDYT about dropping python 3.7 instead?
Not arguing one is better than the other, just trying to get a better perspective.

In any case, feel free to merge as is

@palfrey
Copy link
Contributor Author

palfrey commented Jul 21, 2025

Hi @palfrey

Thanks a lot for the fix.

WDYT about dropping python 3.7 instead? Not arguing one is better than the other, just trying to get a better perspective.

In any case, feel free to merge as is

I'm pro dropping 3.7 (and 3.8 TBH given it's EoL), but wasn't sure if you needed it still. It doesn't cause any maintenance issues yet AFAIK.

@koiuo
Copy link
Owner

koiuo commented Jul 21, 2025

@palfrey

I'm pro dropping 3.7 (and 3.8 TBH given it's EoL)

Removing up to 3.8 is fine with me.
LMK if you'd be willing to make the change.

@palfrey palfrey changed the title Lockdown ubuntu version to one that works with 3.7 Update Python versions to 3.9-3.13 Jul 21, 2025
@palfrey
Copy link
Contributor Author

palfrey commented Jul 21, 2025

@palfrey

I'm pro dropping 3.7 (and 3.8 TBH given it's EoL)

Removing up to 3.8 is fine with me. LMK if you'd be willing to make the change.

Done. Tried adding 3.12/3.13, but they both hit setuptools issues, due to a combination of https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html and https://bugs.launchpad.net/pbr/+bug/2107732

@palfrey
Copy link
Contributor Author

palfrey commented Jul 21, 2025

In any case, feel free to merge as is

For reference, I can't merge this as you're the one with the permissions there :)

@koiuo koiuo merged commit 34e65df into koiuo:master Jul 22, 2025
3 checks passed
@koiuo
Copy link
Owner

koiuo commented Jul 22, 2025

For reference, I can't merge this as you're the one with the permissions there :)

Sorry, haven't touched this in a while, so I forgot how it is 😃

@palfrey palfrey deleted the lockdown-ubuntu-version branch July 22, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants