-
Notifications
You must be signed in to change notification settings - Fork 12
feat: add reduction ops conversion for MPI + cleanup impl #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
fa9a7e1 to
8d76720
Compare
845b50b to
f0ca12d
Compare
cedricchevalier19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Gabriel Dos Santos <[email protected]>
Signed-off-by: Gabriel Dos Santos <[email protected]>
Signed-off-by: Gabriel Dos Santos <[email protected]>
42cafbf to
d4da0db
Compare
cedricchevalier19
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure how to test the dispatch logic, perhaps adding a unit test that almost looks like your implementation but that can save us later when changing the reduction op dispatch.
Can you use these reduction op in MPI, in this PR?
Can we make something to be able to know if a reduction operator is implemented for a given CommunicationSpace?
Yes, definitely. I will add conversion tests in this PR.
Do you mean for the existing low-level MPI reduction interfaces we have? I could, but this would mean that these no longer take an
I could write a helper function like: template <CommunicationSpace CS, ReductionOperator RO>
auto is_reduction_op_convertible() -> bool;Is this what you meant? Additionally, this could become part of the constraints on the |
CommSpace-genericMPI_OpLXorandBXoroperators