Skip to content

feat(core, mpi): add non-blocking MPI all-reduce and expose in "core" API #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dssgabriel wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat(core, mpi): add non-blocking MPI all-reduce and expose in "core" API #197

dssgabriel wants to merge 6 commits into from

Conversation

@dssgabriel
Copy link
Collaborator

@dssgabriel dssgabriel commented Dec 4, 2025 •
edited
Loading

Prepare for exposure in "core" API.

Based on #187 and #188.

@dssgabriel
refactor!: rework & improve communication space concept
c5b28ca 
Signed-off-by: Gabriel Dos Santos <[email protected]>
@dssgabriel
chore: format + fix CommSpace typo in unit test
a1f4b36 
Signed-off-by: Gabriel Dos Santos <[email protected]>
@dssgabriel
refactor: comm space generic reduction operator conversion
f0ca12d 
Signed-off-by: Gabriel Dos Santos <[email protected]>
@dssgabriel
fix: properly define reduction op structs in macro
37001ee 
Signed-off-by: Gabriel Dos Santos <[email protected]>
@dssgabriel
feat(mpi): add non-blocking all-reduce (mpi::iallreduce)
e73d027 
Prepare for exposure in "core" API.

Signed-off-by: Gabriel Dos Santos <[email protected]>
@dssgabriel
feat(core): expose MPI-based allreduce
41fb0ac 
Added associated unit test.

Signed-off-by: Gabriel Dos Santos <[email protected]>
@dssgabriel dssgabriel self-assigned this Dec 4, 2025
@dssgabriel dssgabriel added C-enhancement Category: an enhancement or bug fix A-mpi Area: KokkosComm MPI backend implementation labels Dec 4, 2025
@dssgabriel
Copy link
Collaborator Author

dssgabriel commented Dec 4, 2025

I mistakenly pushed the wrong branch; this one also includes the exposure of the MPI-based allreduce in the "core" API.
I can close and reopen with the correct branch, or we can merge this in one go if reviewers are OK.

@dssgabriel dssgabriel changed the title feat(mpi): add non-blocking all-reduce (mpi::iallreduce) feat(core, mpi): add non-blocking MPI all-reduce and expose in "core" API Dec 4, 2025
@dssgabriel dssgabriel added A-core Area: KokkosComm core library implementation A-unit-tests Area: KokkosComm unit tests labels Dec 4, 2025
@cwpearson cwpearson added the SNL-CI-APPROVAL Required to run SNL CI on non-SNL contributions label Dec 4, 2025
@dssgabriel dssgabriel mentioned this pull request Dec 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwpearson cwpearson Awaiting requested review from cwpearson

@cedricchevalier19 cedricchevalier19 Awaiting requested review from cedricchevalier19

At least 1 approving review is required to merge this pull request.

Assignees

@dssgabriel dssgabriel

Labels

A-core Area: KokkosComm core library implementation A-mpi Area: KokkosComm MPI backend implementation A-unit-tests Area: KokkosComm unit tests C-enhancement Category: an enhancement or bug fix SNL-CI-APPROVAL Required to run SNL CI on non-SNL contributions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dssgabriel @cwpearson