refactor!: add more requirements to the CommunicationSpace concept
#188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dssgabriel
added
C-enhancement
dssgabriel
changed the title
CommunicationSpace concept
This was referenced Dec 4, 2025
cwpearson
added
the
SNL-CI-APPROVAL
Signed-off-by: Gabriel Dos Santos <[email protected]>
Signed-off-by: Gabriel Dos Santos <[email protected]>
Signed-off-by: Cedric Chevalier <[email protected]>
cedricchevalier19
force-pushed
the
refactor/comm-space-concept
branch
from
a1f4b36 to
8047a39
Compare
Signed-off-by: Cedric Chevalier <[email protected]>
Signed-off-by: Cedric Chevalier <[email protected]>
cedricchevalier19
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR constrains the
CommunicationSpaceconcept with the following required member type aliases:typename communication_spacetypename handle_typetypename request_typetypename datatype_typetypename reduction_op_typetypename rank_typeOf course, we may add more/remove some of these in the future.
This allows us to implement
CommunicationSpace-generic APIs for Kokkos Comm (e.g. the datatype conversion alternative mentioned in #186).I also renamed our existing communication spaces
MpiandNccltoMpiSpaceandNcclSpacerespectively, and propagated the change everywhere necessary.This removes any naming ambiguity, matches the name of the header they are declared in, and also happens to correspond to the naming semantic using in Kokkos Remote Spaces (see, e.g., https://github.com/kokkos/kokkos-remote-spaces/blob/main/src/impl/mpispace/Kokkos_MPISpace.hpp).