Skip to content

Conversation

@crtrott
Copy link
Member

@crtrott crtrott commented Sep 1, 2022

No description provided.

@crtrott crtrott mentioned this pull request Sep 1, 2022
reference_type operator() (const IntType& ... indices) const
reference_type operator[] (const IntType& i) const
```
Returns a value of `reference_type` which may or not be referenceable itself. Only valid valid for rank-1 views.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"valid" is repeated twice

* `uniform_nomemspace_type`: uses unified layout and `AnonymousSpace`.
* `uniform_const_nomemspace_type`: `uniform_nomemspace_type` with const data type.
* `uniform_runtime_nomemspace_type`: uses unified layout, all runtime extents and `AnonymousSpace`.
* `uniform_runtime_const_nomemspace_type`: `uniform_runtime_nomemspace_type` with const data type.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all these new above supposed to be under "spaces"? or should be under "viewTypes" ?

@fnrizzi
Copy link
Collaborator

fnrizzi commented Sep 7, 2022

@crtrott pinging you just in case

@fnrizzi fnrizzi marked this pull request as draft October 27, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants