add clang-format option from env variable#382
Merged
IvanGrigorik merged 2 commits intomainfrom Feb 28, 2026
Merged
Conversation
IvanGrigorik
force-pushed
the
grigorik/format-option
branch
from
f8bac1d to
ceddfbb
Compare
kennykos
requested changes
Feb 27, 2026
Collaborator
kennykos
left a comment
kennykos
left a comment
There was a problem hiding this comment.
Can we add documentation for the environment variable before this is merged in?
Collaborator
Author
added |
kennykos
approved these changes
Feb 27, 2026
Collaborator
kennykos
left a comment
kennykos
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me.
JBludau
reviewed
Feb 28, 2026
| self.lib_path_env: str = "PK_KOKKOS_LIB_PATH" | ||
|
|
||
| self.format: bool = False | ||
| self.format: bool = os.getenv("PK_FORMAT") is not None |
Contributor
There was a problem hiding this comment.
Just out of curiosity: this also formats with PK_FORMAT=0?
Collaborator
There was a problem hiding this comment.
Great catch, sorry I missed this in my code review. It should be something like os.getenv("PK_FORMAT", False) , which will default to False if not available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it was said in this issue:
#380 (comment)
We should have total flexibility over our tool, including formatting of intermediate files, if needed
This PR adds
PK_FORMATenv variable dependency, so whenexport PK_FORMAT=1we will doclang-formatpass on our IR files