Skip to content

add clang-format option from env variable #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IvanGrigorik merged 2 commits into from
Feb 28, 2026
Merged

add clang-format option from env variable #382

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ceddfbb
add clang-format option from env variable
IvanGrigorik Feb 27, 2026
23b9658
add env variables description
IvanGrigorik Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pykokkos/core/cpp_setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def __init__(self, module_file: str, gpu_module_files: List[str]):

self.lib_path_env: str = "PK_KOKKOS_LIB_PATH"

self.format: bool = False
self.format: bool = os.getenv("PK_FORMAT") is not None
Copy link
Copy Markdown
Contributor

@JBludau JBludau Feb 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: this also formats with PK_FORMAT=0?

Copy link
Copy Markdown
Collaborator

@kennykos kennykos Mar 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, sorry I missed this in my code review. It should be something like os.getenv("PK_FORMAT", False) , which will default to False if not available


def compile_raw_source(
self,
Expand Down