Choose memory space from policy execution space#389
Merged
Conversation
Currently, pykokkos chooses a memory space based off the default execution space, which leads to bugs when there is a mismatch between policy and default execution spaces. This PR requires a memory space to be explicitly passed in to pk.array, ensuring that the python array api object is cast to the correct memory space.
IvanGrigorik
requested changes
Mar 5, 2026
Collaborator
IvanGrigorik
left a comment
IvanGrigorik
left a comment
There was a problem hiding this comment.
Overall LG
One comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, pykokkos chooses a memory space based off the default execution space, which leads to bugs
when there is a mismatch between policy and default execution spaces.
This PR requires a memory space to be explicitly passed into
convert_array, ensuring that the python array api object is cast to the correct memory space.