Remove deprecated workloads for examples/other directory#396
Remove deprecated workloads for examples/other directory#396nayyirahsan wants to merge 14 commits intokokkos:mainfrom
Conversation
|
A CI like https://github.com/kokkos/pykokkos/pull/395/changes#diff-f25465d66485d3d4df54940b0956531859e73d7212e8ad78ddbecb34a35cc373 would be nice. However, maybe we should set it to a nightly run as not to waste resources. @IvanGrigorik, @JBludau do you have any thoughts on this? |
|
I am 100% agreed. Nightly builds are redundant, we can do it per PR |
|
I excluded |
Thanks! Could you open an issue with this error and link to this PR? Then I'll do code review. |
kennykos
left a comment
kennykos
left a comment
There was a problem hiding this comment.
This looks great, I have some minor suggestions so the code will run out-of-the-box on GPUs.
Co-authored-by: Gabriel Kosmacher <73120774+kennykos@users.noreply.github.com>
Co-authored-by: Gabriel Kosmacher <73120774+kennykos@users.noreply.github.com>
Co-authored-by: Gabriel Kosmacher <73120774+kennykos@users.noreply.github.com>
|
@nayyirahsan I will push the fix to this branch, we just need to include pykokkos/pykokkos/interface/__init__.py Line 60 in 2a48381 Thats on me, I thought I did this in #389 |
kennykos
left a comment
kennykos
left a comment
There was a problem hiding this comment.
The work looks good so far, I've made some requests that should make the examples more helpful to a new pykokkos user.
| print(view) | ||
| print(permute_vector) | ||
| print(bin_offsets) | ||
| print(bin_count) |
There was a problem hiding this comment.
Can you add more detail to the print statements so the user knows what they are looking at when they run the script?
There was a problem hiding this comment.
Also, can you verify that lines 29-31 print something? My guess is that they print None, which is not the expected behavior. This is a larger issue with how functions are translated outside of workunits, @IvanGrigorik should take a look at https://github.com/kokkos/pykokkos/blob/2a483815c3315f34e382b5d61b0a97c8a8425437/pykokkos/interface/bin_sort.py and we should discuss what is going on here
There was a problem hiding this comment.
Confirmed they print None since get_permute_vector(), get_bin_offsets(), and get_bin_count() are all stubs in bin_sort.py. The descriptive labels in the prints make it clear what each value is supposed to represent. Happy to open a separate issue for it
3 participants
Continues #395 , converting remaining examples/ subdirectories to standalone style. Rewrites bfs_bottomup.py, binsort.py, classtypes.py, and subviews.py to use NumPy arrays and module-level workunits, removing all @pk.workload classes as part of the broader workload deprecation tracked in #326 .