build: Use normalized platform spec for ARG expansion

[slimreaper35]

No description provided.

[snyk-io]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[chmeliik]

Isn't DefaultSpec() always normalized? I think Normalize() is more for user input.

[slimreaper35]

Isn't DefaultSpec() always normalized? I think Normalize() is more for user input.

I didn't find the normalization anywhere.

I encountered this while running integration tests, and the platform variant was part of the TARGETPLATFORM/BUILDPLATFORM string:

Test Failure: image label: BUILDPLATFORM=linux/arm64; containerfile label: BUILDPLATFORM=linux/arm64/v8

So the normalization removes the v8 variant, and the test passes. I believe this condition could be dropped as well (unless there is a different solution).

[chmeliik]

Isn't DefaultSpec() always normalized? I think Normalize() is more for user input.

I didn't find the normalization anywhere.

I encountered this while running integration tests, and the platform variant was part of the TARGETPLATFORM/BUILDPLATFORM string:

Test Failure: image label: BUILDPLATFORM=linux/arm64; containerfile label: BUILDPLATFORM=linux/arm64/v8

So the normalization removes the v8 variant, and the test passes.

Ah, interesting. In that case yeah, normalization makes sense. Could you also submit a similar patch to https://github.com/konflux-ci/dockerfile-json/ (the dev branch)?

I believe this condition could be dropped as well (unless there is a different solution).

I think the condition will have to be more specific and also expect empty for arm64 v8. Because the variant label should apparently be empty on arm64 v8 but not any other arm variant

[slimreaper35]

I think the condition will have to be more specific and also expect empty for arm64 v8.

Only for the arm64?

[chmeliik]

I think the condition will have to be more specific and also expect empty for arm64 v8.

Only for the arm64?

If I understand the normalization correctly, then yes. We expect empty VARIANT if:

• the runtime.GOARCH is not arm*
• the runtime.GOARCH is arm64 and the variant is v8

[chmeliik]

Thanks!