feat(RELEASE-1675): auto generate README.md files for tasks/pipelines (#1)#1157
Conversation
|
I split up this PR into five parts to try to get tests to pass Original PR here: #1147 |
04b1a01 to
e16dc3e
Compare
|
Some of the comments on this PR would also apply to |
7eca95a
|
Added |
0206fc3 to
6a2eeab
Compare
04ec51b to
7d5a266
Compare
54f5eef to
34c15c5
Compare
johnbieren
left a comment
There was a problem hiding this comment.
The error messages in the script look good, but can you also please add a note in CONTRIBUTING.md about the script? Under the submitting changes section? Bonus points if you add a bullet point to pull_request_template.md like I have run the README.md generator script in .github/scripts/readme_generator.sh
As part of the CONTRIBUTING.md update, you should also say where the changes should be made. Should I update the parameter in the yaml or the README? Which one takes priority? Same for the overall description (I know we said to use the README for source of truth to update them all, but once that is done, perhaps the yaml should be source of truth for everything and we will never have to manually touch the README.md files) |
|
I had a note in CONTRIBUTING.md, looks like I forgot to push it when I was updating these PRs - I added it back in The yaml files are the source of truth for the README, we shouldn't have to manually update the README.md files at all. A lot of ways to update yaml files in the CLI (such as |
e567831 to
7af78f6
Compare
|
Sean and Fitz already approved the bash scripts, so I didn't review those two files. But I will mark this PR approved once my one comment is addressed |
7991633 to
def3f36
Compare
|
There were some minor changes to the bash scripts after they reviewed it (mainly just a few changes to the error messages), but otherwise it should be fine |
Add readme_generator.sh, which generates README.md files for tasks and pipelines, as well as a check_readme.sh script and workflow to check that the README.md files in each task and pipeline match the output of readme-generator.sh. Also updated CONTRIBUTING.md to mention this new requirement. Add check in check_readme.sh to stop '.' from being added to the end of task/pipeline param descriptions. Signed-off-by: Paul Fitzgerald <pafitzge@redhat.com>
|
New changes are detected. LGTM label has been removed. |
…#1157) Add readme_generator.sh, which generates README.md files for tasks and pipelines, as well as a check_readme.sh script and workflow to check that the README.md files in each task and pipeline match the output of readme-generator.sh. Also updated CONTRIBUTING.md to mention this new requirement. Add check in check_readme.sh to stop '.' from being added to the end of task/pipeline param descriptions. Signed-off-by: Paul Fitzgerald <pafitzge@redhat.com>
Describe your changes
Add readme_generator.sh, which generates README.md files for tasks and pipelines, as well as a check_readme.sh script and workflow to check that the README.md files in each task and pipeline match the output of readme-generator.sh.
Relevant Jira
https://issues.redhat.com/browse/RELEASE-1675
Checklist before requesting a review
do not mergelabel if there's a dependency PRrelease-service-maintainershandle if you are unsure who to tagSigned-off-by: My name <email>