Skip to content

feat(RELEASE-1675): auto generate README.md files for tasks/pipelines (#1)#1157

Merged
johnbieren merged 1 commit into
konflux-ci:developmentfrom
Paul123111:auto-readme-1
Jul 9, 2025
Merged

feat(RELEASE-1675): auto generate README.md files for tasks/pipelines (#1)#1157
johnbieren merged 1 commit into
konflux-ci:developmentfrom
Paul123111:auto-readme-1

Conversation

@Paul123111

Copy link
Copy Markdown
Contributor

Describe your changes

Add readme_generator.sh, which generates README.md files for tasks and pipelines, as well as a check_readme.sh script and workflow to check that the README.md files in each task and pipeline match the output of readme-generator.sh.

Relevant Jira

https://issues.redhat.com/browse/RELEASE-1675

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I read CONTRIBUTING.MD and commit formatting

@Paul123111 Paul123111 requested a review from a team as a code owner July 2, 2025 11:00
@Paul123111

Copy link
Copy Markdown
Contributor Author

I split up this PR into five parts to try to get tests to pass

Original PR here: #1147

Comment thread .github/scripts/check_readme.sh
Comment thread .github/scripts/check_readme.sh Outdated
Comment thread .github/workflows/check_readme.yaml Outdated
Comment thread .github/scripts/check_readme.sh Outdated
Comment thread .github/scripts/check_readme.sh Outdated
Comment thread .github/scripts/check_readme.sh Outdated
Comment thread .github/scripts/check_readme.sh Outdated
Comment thread .github/scripts/check_readme.sh Outdated
@Paul123111 Paul123111 force-pushed the auto-readme-1 branch 4 times, most recently from 04b1a01 to e16dc3e Compare July 2, 2025 13:49
@Paul123111

Copy link
Copy Markdown
Contributor Author

Some of the comments on this PR would also apply to test_tekton_tasks.sh

FilipNikolovski
FilipNikolovski previously approved these changes Jul 3, 2025
seanconroy2021
seanconroy2021 previously approved these changes Jul 3, 2025
@Paul123111 Paul123111 changed the title feat(RELEASE-1675): auto generate README.md files for tasks/pipelines feat(RELEASE-1675): auto generate README.md files for tasks/pipelines (#1) Jul 3, 2025
@Paul123111 Paul123111 dismissed stale reviews from seanconroy2021 and FilipNikolovski via 7eca95a July 3, 2025 13:30
@openshift-ci openshift-ci Bot removed the lgtm label Jul 3, 2025
@Paul123111

Copy link
Copy Markdown
Contributor Author

Added check_param_punctuation.sh and workflow from Martin's comment in one of the other PRs.

@Paul123111 Paul123111 force-pushed the auto-readme-1 branch 2 times, most recently from 0206fc3 to 6a2eeab Compare July 3, 2025 15:54
Comment thread .github/workflows/lint.yaml Outdated
@Paul123111 Paul123111 force-pushed the auto-readme-1 branch 2 times, most recently from 04ec51b to 7d5a266 Compare July 4, 2025 09:56
Comment thread .github/scripts/check_readme.sh Outdated
Comment thread .github/scripts/check_readme.sh
Comment thread .github/workflows/lint.yaml
Comment thread hack/readme_generator.sh
@Paul123111 Paul123111 force-pushed the auto-readme-1 branch 4 times, most recently from 54f5eef to 34c15c5 Compare July 8, 2025 11:17

@johnbieren johnbieren left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error messages in the script look good, but can you also please add a note in CONTRIBUTING.md about the script? Under the submitting changes section? Bonus points if you add a bullet point to pull_request_template.md like I have run the README.md generator script in .github/scripts/readme_generator.sh

@johnbieren

Copy link
Copy Markdown
Collaborator

The error messages in the script look good, but can you also please add a note in CONTRIBUTING.md about the script? Under the submitting changes section? Bonus points if you add a bullet point to pull_request_template.md like I have run the README.md generator script in .github/scripts/readme_generator.sh

As part of the CONTRIBUTING.md update, you should also say where the changes should be made. Should I update the parameter in the yaml or the README? Which one takes priority? Same for the overall description (I know we said to use the README for source of truth to update them all, but once that is done, perhaps the yaml should be source of truth for everything and we will never have to manually touch the README.md files)

@Paul123111

Paul123111 commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

I had a note in CONTRIBUTING.md, looks like I forgot to push it when I was updating these PRs - I added it back in

The yaml files are the source of truth for the README, we shouldn't have to manually update the README.md files at all. A lot of ways to update yaml files in the CLI (such as yq) break formatting (for example, any descriptions with > get folded into one line in the yaml file, failing yamllint) in some places, so I think it would be better if the yaml files were the source of truth rather than the README.

Comment thread CONTRIBUTING.md Outdated
@johnbieren

Copy link
Copy Markdown
Collaborator

Sean and Fitz already approved the bash scripts, so I didn't review those two files. But I will mark this PR approved once my one comment is addressed

@Paul123111 Paul123111 force-pushed the auto-readme-1 branch 2 times, most recently from 7991633 to def3f36 Compare July 9, 2025 14:39
@Paul123111

Copy link
Copy Markdown
Contributor Author

There were some minor changes to the bash scripts after they reviewed it (mainly just a few changes to the error messages), but otherwise it should be fine

Add readme_generator.sh, which generates README.md files
for tasks and pipelines, as well as a check_readme.sh script and
workflow to check that the README.md files in each task and pipeline
match the output of readme-generator.sh. Also updated CONTRIBUTING.md
to mention this new requirement.

Add check in check_readme.sh to stop '.' from being
added to the end of task/pipeline param descriptions.

Signed-off-by: Paul Fitzgerald <pafitzge@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 9, 2025

Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@johnbieren johnbieren merged commit c60ae2d into konflux-ci:development Jul 9, 2025
9 checks passed
@Paul123111 Paul123111 deleted the auto-readme-1 branch July 9, 2025 15:36
happybhati pushed a commit that referenced this pull request Sep 11, 2025
…#1157)

Add readme_generator.sh, which generates README.md files
for tasks and pipelines, as well as a check_readme.sh script and
workflow to check that the README.md files in each task and pipeline
match the output of readme-generator.sh. Also updated CONTRIBUTING.md
to mention this new requirement.

Add check in check_readme.sh to stop '.' from being
added to the end of task/pipeline param descriptions.

Signed-off-by: Paul Fitzgerald <pafitzge@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants