Skip to content

fix(deps): update knative.dev/pkg digest to 6300c57#1709

Merged
swickersh merged 1 commit into
mainfrom
konflux/mintmaker/main/knative.dev-pkg-digest
Jun 22, 2026
Merged

fix(deps): update knative.dev/pkg digest to 6300c57#1709
swickersh merged 1 commit into
mainfrom
konflux/mintmaker/main/knative.dev-pkg-digest

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
knative.dev/pkg require digest ac97e436300c57

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 4 additional dependencies were updated

Details:

Package Change
k8s.io/api v0.35.5 -> v0.35.6
k8s.io/apiserver v0.35.5 -> v0.35.6
k8s.io/apiextensions-apiserver v0.35.5 -> v0.35.6
k8s.io/component-base v0.35.5 -> v0.35.6

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 18, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:30 PM UTC · Completed 10:33 PM UTC
Commit: 218f229 · View workflow run →

@fullsend-ai-review

fullsend-ai-review Bot commented Jun 18, 2026

Copy link
Copy Markdown

Looks good to me

Previous run

Review

Findings

Low

  • [version skew] go.mod:170 — Pre-existing: the replace directive pins k8s.io/client-go to v0.35.4 while this PR bumps other k8s.io packages (api, apiserver, apiextensions-apiserver, component-base) to v0.35.6. This widens the patch-level skew to 2 patch versions. Within a 0.35.x series this is unlikely to cause runtime issues, but the skew is growing with each bump. Consider updating the replace directive to v0.35.6 to keep all k8s.io 0.35.x packages aligned.
Previous run (2)

Looks good to me

Previous run (3)

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jun 18, 2026
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.30%. Comparing base (8d113fa) to head (35d9855).

❗ There is a different number of reports uploaded between BASE (8d113fa) and HEAD (35d9855). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (8d113fa) HEAD (35d9855)
unit-tests 2 1
e2e-tests 1 0
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   87.23%   81.30%   -5.93%     
==========================================
  Files          34       34              
  Lines        3542     3542              
==========================================
- Hits         3090     2880     -210     
- Misses        287      513     +226     
+ Partials      165      149      -16     
Flag Coverage Δ
e2e-tests ?
unit-tests 81.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 12 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d113fa...35d9855. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update knative.dev/pkg digest to 6300c57 fix(deps): update knative.dev/pkg digest to 6300c57 - autoclosed Jun 22, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jun 22, 2026
@red-hat-konflux red-hat-konflux Bot deleted the konflux/mintmaker/main/knative.dev-pkg-digest branch June 22, 2026 02:23
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 2:25 AM UTC · Completed 2:31 AM UTC
Commit: 218f229 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #1709 — Dependency digest bump (autoclosed)

This was an automated MintMaker/Renovate dependency update PR (knative.dev/pkg digest bump + 4 transitive k8s dep updates). The review agent ran in ~6 minutes, approved with "Looks good to me", and the PR was autoclosed by MintMaker ~4 days later without being merged.

Timeline

  • Jun 18 22:27 — PR opened by red-hat-konflux[bot]
  • Jun 18 22:30–22:33 — Review agent ran and approved (run 27793182856)
  • Jun 18 22:33 — Bot's own approval triggered a second fullsend dispatch (self-triggering loop)
  • Jun 22 02:23 — PR autoclosed by MintMaker
  • Jun 22 02:23–02:26 — PR close triggered 4 review runs + 2 retro runs (all redundant)

Issues identified (all already tracked)

Every improvement opportunity is covered by existing open issues in fullsend-ai/fullsend:

  1. Redundant reviews on PR close#1870 (skip review/fix dispatch when action is 'closed') and #1439 (skip review dispatch when PR is already closed/merged)
  2. Retro on autoclosed bot PRs#2461 (skip retro dispatch for autoclosed bot-authored PRs)
  3. Self-triggering review loop#1271 (filter bot-triggered pull_request_review events)
  4. Duplicate retro runs#2401 (deduplicate retro runs on same PR)
  5. Lightweight review for dep bumps#1358 (add lightweight review path for trivial bot dependency bumps)

No new proposals are warranted — the existing issue backlog comprehensively covers the waste observed here. Prioritizing #1870 and #2461 would eliminate the most obvious waste (6+ redundant agent runs on this single PR close event).

@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update knative.dev/pkg digest to 6300c57 - autoclosed fix(deps): update knative.dev/pkg digest to 6300c57 Jun 22, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jun 22, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/knative.dev-pkg-digest branch 2 times, most recently from d67b2fb to 59d14d8 Compare June 22, 2026 06:37
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 6:39 AM UTC · Completed 6:43 AM UTC
Commit: 218f229 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Jun 22, 2026
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/knative.dev-pkg-digest branch from 59d14d8 to a533511 Compare June 22, 2026 10:30
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:32 AM UTC · Completed 10:37 AM UTC
Commit: 218f229 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Jun 22, 2026
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot force-pushed the konflux/mintmaker/main/knative.dev-pkg-digest branch from a533511 to 35d9855 Compare June 22, 2026 14:41
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:44 PM UTC · Completed 2:47 PM UTC
Commit: 7acff03 · View workflow run →

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge and removed ready-for-merge All reviewers approved — ready to merge labels Jun 22, 2026
@swickersh swickersh added this pull request to the merge queue Jun 22, 2026
Merged via the queue into main with commit e4810b6 Jun 22, 2026
18 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 5:07 PM UTC · Completed 5:12 PM UTC
Commit: 0d0162a · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #1709 — Dependency digest bump (full lifecycle)

This was an automated MintMaker/Renovate PR updating knative.dev/pkg digest + 4 transitive k8s.io packages (2 files changed, go.mod/go.sum). The PR had a turbulent lifecycle: opened Jun 18, autoclosed Jun 22 02:23, reopened Jun 22 06:37, force-pushed 4 times, and finally merged Jun 22 17:05.

Waste observed

Run type Count Useful Redundant
Review ~6 1 ~5
Retro 2 1 1

Each review produced the same "Looks good to me" approval for an identical trivial dependency bump. The only substantive finding (low-severity k8s.io/client-go version skew) was noted once and never acted on.

Root causes (all already tracked)

All waste patterns observed on this PR are covered by existing open issues in fullsend-ai/fullsend:

  • Force-push re-reviews on bot dep bumps: #1355, #1372, #1418
  • Reviews triggered on closed PRs: #1870, #1439
  • Self-triggering from bot approval: #1271
  • Lightweight review for trivial dep bumps: #1358
  • Duplicate retro runs: #2401
  • Retro on autoclosed bot PRs: #2461

The earlier retro run (triggered by the autoclose event) already identified these same issues. This retro run is itself a duplicate (#2401). No new proposals warranted — prioritizing #1355, #1870, and #2461 would eliminate the majority of the waste seen here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants