Add search-variants-mapi tool #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynekh
force-pushed
the
search-variants-mapi
branch
4 times, most recently
from
0476582 to
01ce7ba
Compare
PetrSvirak
reviewed
Sep 9, 2025
PetrSvirak
reviewed
Sep 9, 2025
zbynekh
force-pushed
the
search-variants-mapi
branch
2 times, most recently
from
7c09fba to
ac6e237
Compare
PetrSvirak
reviewed
Sep 9, 2025
PetrSvirak
reviewed
Sep 9, 2025
JiriLojda
approved these changes
Sep 9, 2025
PetrSvirak
reviewed
Sep 9, 2025
PetrSvirak
reviewed
Sep 9, 2025
|
|
||
| const data: AiOperationResultResponse = pollResponse.data; | ||
|
|
||
| if (data.message.includes("still in progress")) { |
There was a problem hiding this comment.
This does not block this task, but: Why is there "still in progress" text in a message? We are using REST over HTTP, so we should return:
- 404 until first message is stored in DB
- 201 until last message is stored in DB (
isLast == true) - 200 while the last message is cached
- 404 after the last message is removed from cache
There was a problem hiding this comment.
Will be addressed in a separate issue.
zbynekh
force-pushed
the
search-variants-mapi
branch
from
ac6e237 to
2ae89ac
Compare
zbynekh
force-pushed
the
search-variants-mapi
branch
from
2ae89ac to
830e6ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?