EN-584 - update the SKD and use new variant filter endpoint #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winklertomas
force-pushed
the
EN-584_update_the_SKD_and_use_new_variant_filter_endpoint
branch
from
b6540cd to
9392843
Compare
huluvu21
requested changes
Sep 29, 2025
src/tools/filter-variants-mapi.ts
Outdated
| .withAction(`projects/${environmentId}/early-access/variants/filter`) | ||
| .withData(requestPayload) | ||
| .toPromise(); | ||
| const response = await query.toPromise(); |
There was a problem hiding this comment.
Why not to use the same approach as in other listing tools? Something like in list-assets-mapi for example? Meaning using toAllPromise. That way the AI agent doesn't need to know about paging and continuation tokens...
There was a problem hiding this comment.
I didn't know the toAllPromise() SDK method, I will fix that :-)
package.json
Outdated
| "license": "MIT", | ||
| "dependencies": { | ||
| "@kontent-ai/management-sdk": "^7.9.0", | ||
| "@kontent-ai/management-sdk": "^7.11.0-4", |
There was a problem hiding this comment.
I think that after we approve the PR for the SDK, Risa is going to release new version (not pre-release). That means we should probably wait for that...
winklertomas
force-pushed
the
EN-584_update_the_SKD_and_use_new_variant_filter_endpoint
branch
2 times, most recently
from
ba274f0 to
036d44a
Compare
huluvu21
requested changes
Sep 29, 2025
README.md
Outdated
| * **create-variant-version-mapi** – Create new version of Kontent.ai language variant via Management API. This operation creates a new version of an existing language variant, useful for content versioning and creating new drafts from published content | ||
| * **delete-language-variant-mapi** – Delete Kontent.ai language variant from Management API | ||
| * **filter-variants-mapi** – Filter Kontent.ai language variants of content items using Management API. Use for exact keyword matching and finding specific terms in content. Supports full filtering capabilities (content types, workflow steps, taxonomies, etc.) | ||
| * **filter-variants-mapi** – Filter Kontent.ai language variants of content items using Management API. Use for exact keyword matching and finding specific terms in content. Supports full filtering capabilities (content types, workflow steps, taxonomies, etc.), pagination with continuation tokens, and optionally includes full content of variants |
There was a problem hiding this comment.
I wouldn't confuse the AI agent with any continuation tokens anymore :)
src/tools/filter-variants-mapi.ts
Outdated
| const allItems = response.responses.flatMap((r) => r.rawData.data); | ||
|
|
||
| return createMcpToolSuccessResponse(response.data); | ||
| return createMcpToolSuccessResponse({ data: allItems }); |
There was a problem hiding this comment.
Is there a reason to return an object instead of the array of all items?
winklertomas
force-pushed
the
EN-584_update_the_SKD_and_use_new_variant_filter_endpoint
branch
from
036d44a to
01dd42f
Compare
huluvu21
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?