Skip to content

Fix average score by ignoring unknown grades and hiding ungraded marks #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix average score by ignoring unknown grades and hiding ungraded marks #662

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc00d58
Initial plan
Copilot Jan 22, 2026
6cc8535
hide unknown marks and compute average from graded only
Copilot Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/app/[locale]/(private)/module/vedomoststud/components/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@ export default function SessionTable({ termResults }: { termResults: TermResults
['date', 'mark', 'assessmentType', 'recordType'],
);

const gradedDisciplines = termResults.disciplines.filter(
(discipline) => discipline.status !== Status.Unknown && discipline.mark !== undefined && discipline.mark !== null,
);

const averageScore =
gradedDisciplines.length > 0
? (gradedDisciplines.reduce((sum, discipline) => sum + Number(discipline.mark ?? 0), 0) / gradedDisciplines.length).toFixed(2)
: '—';

return (
<Card className="rounded-b-6 col-span-full w-full bg-white p-6 xl:col-span-5">
<Table>
Expand Down Expand Up @@ -60,7 +69,7 @@ export default function SessionTable({ termResults }: { termResults: TermResults
<TableCell className="w-[120px]">{discipline.date}</TableCell>
<TableCell className="w-[300px]">{discipline.name}</TableCell>
<TableCell className="w-[109px] text-center">
{discipline.mark !== undefined && discipline.mark !== null && (
{discipline.status !== Status.Unknown && discipline.mark !== undefined && discipline.mark !== null && (
<Badge className="text-basic-blue font-semibold">
{Number(discipline.mark)}/{MAX_SCORE}
</Badge>
Expand All @@ -87,7 +96,7 @@ export default function SessionTable({ termResults }: { termResults: TermResults
</Table>
<div className="my-2 flex items-center gap-2 pl-4 whitespace-nowrap">
<Paragraph className="text-base font-normal">{t('average-score')}</Paragraph>
<Badge className="bg-basic-blue text-basic-white font-semibold">{termResults.averageScore}</Badge>
<Badge className="bg-basic-blue text-basic-white font-semibold">{averageScore}</Badge>
</div>
</Card>
);
Expand Down