Skip to content

add help target to Makefile#477

Open
JDRanpariya wants to merge 3 commits intokscalelabs:masterfrom
JDRanpariya:add-makefile-help
Open

add help target to Makefile#477
JDRanpariya wants to merge 3 commits intokscalelabs:masterfrom
JDRanpariya:add-makefile-help

Conversation

@JDRanpariya
Copy link

on doing make or make help it shows available target and intended use.

I think makefile can be improved further to setup dev environment to clean unused stuff, do you guys think it's good idea to do that?

image

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2025

CLA assistant check
All committers have signed the CLA.

@WT-MM WT-MM self-requested a review July 18, 2025 01:35
Copy link
Contributor

@WT-MM WT-MM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This help target makes sense to me. General question about whether we want to tie the message to Python though?

Also can you elaborate on adding targets to clean up the dev environment?

@JDRanpariya
Copy link
Author

I don't understand what you mean by if we want tie the message to Python?

On adding targets to clean up, it's simply make clean that would remove the folders that are generated after you build the project, probably dist or cache folders for ruff and mypy(from make format etc), it's not required tbh, but maybe we can have make install which installs the package instead of doing pip install -e .[dev] etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants