Skip to content

add __init__.py to ensure package-level test discovery#479

Open
JDRanpariya wants to merge 1 commit intokscalelabs:masterfrom
JDRanpariya:fix/test-init
Open

add __init__.py to ensure package-level test discovery#479
JDRanpariya wants to merge 1 commit intokscalelabs:masterfrom
JDRanpariya:fix/test-init

Conversation

@JDRanpariya
Copy link

No description provided.

@WT-MM WT-MM self-requested a review July 18, 2025 01:39
Copy link
Contributor

@WT-MM WT-MM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point of adding the test directory as a valid package? I think we just want to be able to run pytest.

Lmk your rationale for this

@JDRanpariya
Copy link
Author

well for me when I wanted to run pytest -m "slow" --durations 10 I had to add PYTHONPATH=. as prefix, maybe I'm missing something, I guess at some point if tests get slow we might want to run it.

Maybe it's issue with my setup, I installed it with pip install .[dev] and not pip install -e .[dev], something we can add to contribute.md, then you're right we don't need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants