-
Notifications
You must be signed in to change notification settings - Fork 41
fix: Removed use of Inline Yaml in GHA #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: kunal-511 <[email protected]>
|
please prefix the files, such that it is clear to which component the test files belong |
Signed-off-by: kunal-511 <[email protected]>
|
@kunal-511 i talked to @kimwnasptd and he wants to review it for now. |
|
/lgtm Let's resolve the conflicts and we can merge |
Signed-off-by: Kunal Dugar <[email protected]>
resolved |
|
Looking at how this PR is developing, I personally don't like how we are now ending up having test files for components in a different place from those components. I'll approve for now, but I think it's worth discussing whether it makes sense to move the integration tests logic inside each component. And in |
|
Either way, nice work @kunal-511! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/lgtm |
Uh oh!
There was an error while loading. Please reload this page.