Skip to content

Conversation

@kunal-511
Copy link
Contributor

@kunal-511 kunal-511 commented Jul 14, 2025

  • refactored the GitHub Actions workflows to use committed YAML files in the testing/gh-actions/resources/ folder instead of inline YAML commands.
  • Made the helper scripts executable

@kunal-511 kunal-511 changed the title ci :Removed use of Inline Yaml in GHA ci:Removed use of Inline Yaml in GHA Jul 14, 2025
@kunal-511 kunal-511 changed the title ci:Removed use of Inline Yaml in GHA fix :Removed use of Inline Yaml in GHA Jul 14, 2025
@kunal-511
Copy link
Contributor Author

cc: @juliusvonkohout @kimwnasptd

@juliusvonkohout juliusvonkohout changed the title fix :Removed use of Inline Yaml in GHA fix: Removed use of Inline Yaml in GHA Jul 14, 2025
@juliusvonkohout
Copy link
Member

please prefix the files, such that it is clear to which component the test files belong

@juliusvonkohout
Copy link
Member

@kunal-511 i talked to @kimwnasptd and he wants to review it for now.

@kimwnasptd
Copy link
Member

/lgtm

Let's resolve the conflicts and we can merge

@google-oss-prow google-oss-prow bot removed the lgtm label Jul 17, 2025
@kunal-511
Copy link
Contributor Author

/lgtm

Let's resolve the conflicts and we can merge

resolved

@kimwnasptd
Copy link
Member

Looking at how this PR is developing, I personally don't like how we are now ending up having test files for components in a different place from those components.

I'll approve for now, but I think it's worth discussing whether it makes sense to move the integration tests logic inside each component. And in testing/gh-actions to have more generic files needed, like installing dependencies, KinD etc

@kimwnasptd
Copy link
Member

Either way, nice work @kunal-511!

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kimwnasptd
Copy link
Member

/ok-to-test

@kimwnasptd
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 17, 2025
@google-oss-prow google-oss-prow bot merged commit 48963d9 into kubeflow:main Jul 17, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants