fix: Removed use of Inline Yaml in GHA

.github/workflows/central_dashboard_integration_test.yaml

@@ -67,16 +67,7 @@ jobs:
 
     - name: Create Test Profile for Dashboard Testing
       run: |
-        cat <<EOF | kubectl apply -f -
-        apiVersion: kubeflow.org/v1
-        kind: Profile
-        metadata:
-          name: test-dashboard-profile
-        spec:
-          owner:
-            kind: User
-            name: [email protected]
-        EOF
+        kubectl apply -f testing/gh-actions/resources/profile-dashboard-test.yaml
 
         for i in {1..60}; do
           if kubectl get namespace test-dashboard-profile >/dev/null 2>&1; then

.github/workflows/end_to_end_integration_test.yaml

@@ -271,7 +271,6 @@ jobs:
         kubectl get nodes
         kubectl get pods -A
 
-    # Cleanup
     - name: Cleanup Test Resources
       run: |
         ./testing/gh-actions/test_poddefault.sh cleanup e2e-test

testing/gh-actions/resources/poddefault-basic.yaml

@@ -0,0 +1,19 @@
+apiVersion: kubeflow.org/v1alpha1
+kind: PodDefault
+metadata:
+  name: ${PODDEFAULT_NAME}
+  namespace: ${NAMESPACE}
+spec:
+  selector:
+    matchLabels:
+      ${PODDEFAULT_NAME}: "true"
+  desc: "Test PodDefault for integration testing"
+  env:
+  - name: TEST_ENV_VAR
+    value: "test-value"
+  volumes:
+  - name: test-volume
+    emptyDir: {}
+  volumeMounts:
+  - name: test-volume
+    mountPath: /test-mount 

testing/gh-actions/resources/poddefault-invalid.yaml

@@ -0,0 +1,12 @@
+apiVersion: kubeflow.org/v1alpha1
+kind: PodDefault
+metadata:
+  name: invalid-poddefault
+  namespace: ${NAMESPACE}
+spec:
+  selector:
+    matchLabels:
+      invalid: "true"
+  volumeMounts:
+  - name: non-existent-volume
+    mountPath: /invalid 

testing/gh-actions/resources/poddefault-multi-selector.yaml

@@ -0,0 +1,13 @@
+apiVersion: kubeflow.org/v1alpha1
+kind: PodDefault
+metadata:
+  name: ${PODDEFAULT_NAME}-2
+  namespace: ${NAMESPACE}
+spec:
+  selector:
+    matchLabels:
+      test-multi: "true"
+  desc: "Second test PodDefault"
+  env:
+  - name: SECOND_ENV_VAR
+    value: "second-value" 

testing/gh-actions/resources/poddefault-test-pod-multi.yaml

@@ -0,0 +1,13 @@
+apiVersion: v1
+kind: Pod
+metadata:
+  name: ${TEST_POD_NAME}-multi
+  namespace: ${NAMESPACE}
+  labels:
+    ${PODDEFAULT_NAME}: "true"
+    test-multi: "true"
+spec:
+  containers:
+  - name: test-container
+    image: busybox:latest
+    command: ["sleep", "300"] 

testing/gh-actions/resources/poddefault-test-pod.yaml

@@ -0,0 +1,12 @@
+apiVersion: v1
+kind: Pod
+metadata:
+  name: ${TEST_POD_NAME}
+  namespace: ${NAMESPACE}
+  labels:
+    ${PODDEFAULT_NAME}: "true"
+spec:
+  containers:
+  - name: test-container
+    image: busybox:latest
+    command: ["sleep", "3600"] 

testing/gh-actions/resources/profile-dashboard-test.yaml

@@ -0,0 +1,8 @@
+apiVersion: kubeflow.org/v1
+kind: Profile
+metadata:
+  name: test-dashboard-profile
+spec:
+  owner:
+    kind: User
+    name: [email protected] 

testing/gh-actions/resources/profile-simple.yaml

@@ -0,0 +1,8 @@
+apiVersion: kubeflow.org/v1
+kind: Profile
+metadata:
+  name: ${PROFILE_NAME}
+spec:
+  owner:
+    kind: User
+    name: ${USER_EMAIL} 

testing/gh-actions/resources/profile-with-quota.yaml

@@ -0,0 +1,13 @@
+apiVersion: kubeflow.org/v1
+kind: Profile
+metadata:
+  name: ${PROFILE_NAME}
+spec:
+  owner:
+    kind: User
+    name: ${USER_EMAIL}
+  resourceQuotaSpec:
+    hard:
+      cpu: "2"
+      memory: 2Gi
+      requests.nvidia.com/gpu: "1" 

testing/gh-actions/test_poddefault.sh

@@ -18,62 +18,18 @@ case "$OPERATION" in
         ;;
 
     "create-poddefault")
-        cat <<EOF | kubectl apply -f -
-apiVersion: kubeflow.org/v1alpha1
-kind: PodDefault
-metadata:
-  name: ${PODDEFAULT_NAME}
-  namespace: ${NAMESPACE}
-spec:
-  selector:
-    matchLabels:
-      ${PODDEFAULT_NAME}: "true"
-  desc: "Test PodDefault for integration testing"
-  env:
-  - name: TEST_ENV_VAR
-    value: "test-value"
-  volumes:
-  - name: test-volume
-    emptyDir: {}
-  volumeMounts:
-  - name: test-volume
-    mountPath: /test-mount
-EOF
+        export PODDEFAULT_NAME NAMESPACE
+        envsubst < "$(dirname "$0")/resources/poddefault-basic.yaml" | kubectl apply -f -
         ;;
 
     "create-multi-poddefault")
-        cat <<EOF | kubectl apply -f -
-apiVersion: kubeflow.org/v1alpha1
-kind: PodDefault
-metadata:
-  name: ${PODDEFAULT_NAME}-2
-  namespace: ${NAMESPACE}
-spec:
-  selector:
-    matchLabels:
-      test-multi: "true"
-  desc: "Second test PodDefault"
-  env:
-  - name: SECOND_ENV_VAR
-    value: "second-value"
-EOF
+        export PODDEFAULT_NAME NAMESPACE
+        envsubst < "$(dirname "$0")/resources/poddefault-multi-selector.yaml" | kubectl apply -f -
         ;;
 
     "test-mutation")
-        cat <<EOF | kubectl apply -f -
-apiVersion: v1
-kind: Pod
-metadata:
-  name: ${TEST_POD_NAME}
-  namespace: ${NAMESPACE}
-  labels:
-    ${PODDEFAULT_NAME}: "true"
-spec:
-  containers:
-  - name: test-container
-    image: busybox:latest
-    command: ["sleep", "3600"]
-EOF
+        export TEST_POD_NAME NAMESPACE PODDEFAULT_NAME
+        envsubst < "$(dirname "$0")/resources/poddefault-test-pod.yaml" | kubectl apply -f -
 
         kubectl get pod "${TEST_POD_NAME}" -n "${NAMESPACE}" -o yaml | grep -q "TEST_ENV_VAR" || {
             echo "ERROR: TEST_ENV_VAR not found in pod spec"
@@ -89,21 +45,8 @@ EOF
         ;;
 
     "test-multi-mutation")
-        cat <<EOF | kubectl apply -f -
-apiVersion: v1
-kind: Pod
-metadata:
-  name: ${TEST_POD_NAME}-multi
-  namespace: ${NAMESPACE}
-  labels:
-    ${PODDEFAULT_NAME}: "true"
-    test-multi: "true"
-spec:
-  containers:
-  - name: test-container
-    image: busybox:latest
-    command: ["sleep", "300"]
-EOF
+        export TEST_POD_NAME NAMESPACE PODDEFAULT_NAME
+        envsubst < "$(dirname "$0")/resources/poddefault-test-pod-multi.yaml" | kubectl apply -f -
 
         kubectl get pod "${TEST_POD_NAME}-multi" -n "${NAMESPACE}" -o yaml | grep -q "TEST_ENV_VAR" || {
             echo "ERROR: TEST_ENV_VAR not found in pod spec"
@@ -119,20 +62,8 @@ EOF
         ;;
 
     "test-error-handling")
-        cat <<EOF | kubectl apply -f - 
-apiVersion: kubeflow.org/v1alpha1
-kind: PodDefault
-metadata:
-  name: invalid-poddefault
-  namespace: ${NAMESPACE}
-spec:
-  selector:
-    matchLabels:
-      invalid: "true"
-  volumeMounts:
-  - name: non-existent-volume
-    mountPath: /invalid
-EOF
+        export NAMESPACE
+        envsubst < "$(dirname "$0")/resources/poddefault-invalid.yaml" | kubectl apply -f -
         ;;
 
     "validate-webhook")

testing/gh-actions/test_profile.sh

@@ -23,21 +23,8 @@ fi
 
 case "$OPERATION" in
     "create")
-        cat <<EOF | kubectl apply -f -
-apiVersion: kubeflow.org/v1
-kind: Profile
-metadata:
-  name: ${PROFILE_NAME}
-spec:
-  owner:
-    kind: User
-    name: ${USER_EMAIL}
-  resourceQuotaSpec:
-    hard:
-      cpu: "2"
-      memory: 2Gi
-      requests.nvidia.com/gpu: "1"
-EOF
+        export PROFILE_NAME USER_EMAIL
+        envsubst < "$(dirname "$0")/resources/profile-with-quota.yaml" | kubectl apply -f -
         kubectl wait --for=jsonpath='{.metadata.name}'=${PROFILE_NAME} profile "${PROFILE_NAME}" --timeout=60s
         timeout=120
         interval=5
@@ -59,16 +46,8 @@ EOF
         ;;
 
     "create-simple")
-        cat <<EOF | kubectl apply -f -
-apiVersion: kubeflow.org/v1
-kind: Profile
-metadata:
-  name: ${PROFILE_NAME}
-spec:
-  owner:
-    kind: User
-    name: ${USER_EMAIL}
-EOF
+        export PROFILE_NAME USER_EMAIL
+        envsubst < "$(dirname "$0")/resources/profile-simple.yaml" | kubectl apply -f -
         kubectl wait --for=jsonpath='{.metadata.name}'=${PROFILE_NAME} profile "${PROFILE_NAME}" --timeout=60s
         timeout=120
         interval=5