ci: add centraldashboard-angular tests
#96
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
andyatmiami
force-pushed
the
feat/centraldb-angular-ghas
branch
from
0207b2a to
4b19c24
Compare
|
Successful runs of the GHAs being added were observed (before I reverted the change to
ℹ️ @thesuperzapper had mentioned some of these |
Part of kubeflow#74 Please note this PR makes a few modifications to the workflows: - `node-version: 16` has been set for backend (previously `node-version: 12` in `kubeflow/kubeflow` although we build on a `node16` base image) - `frontend` workflows have a reworked `Install dependencies` step that builds off PR kubeflow#92 to ensure `kubeflow-common-lib` built and available - paths updated now that the `testing` folder does not live **under** the `components/` folder - various manifests that reside in `kubeflow/kubeflow` under `components/notebook-controller` and `components/crud-web-apps` are provided to `kustomize` via their GitHub URL as those components weren't migrated to `kubeflow/dashboard` TODO: Add .github/workflows/centraldb_angular_docker_publish.yaml once we are ready for publish/release. Signed-off-by: Andy Stoneberg <[email protected]>
andyatmiami
force-pushed
the
feat/centraldb-angular-ghas
branch
from
4b19c24 to
689203d
Compare
related: #74
Please note this PR makes a few modifications to the workflows:
node-version: 16has been set for backend (previouslynode-version: 12inkubeflow/kubeflowalthough we build on anode16base image)frontendworkflows have a reworkedInstall dependenciesstep that builds off PR fix(dashboard): centraldashboard-angular build with common-lib fetch #92 to ensurekubeflow-common-libbuilt and availabletestingfolder does not live under thecomponents/folderkubeflow/kubeflowundercomponents/notebook-controllerandcomponents/crud-web-appsare provided tokustomizevia their GitHub URL as those components weren't migrated tokubeflow/dashboardTODO: Add .github/workflows/centraldb_angular_docker_publish.yaml once we are ready for publish/release.