Skip to content

Conversation

@andyatmiami
Copy link
Contributor

@andyatmiami andyatmiami commented May 6, 2025

related: #74

Please note this PR makes a few modifications to the workflows:

  • node-version: 16 has been set for backend (previously node-version: 12 in kubeflow/kubeflow although we build on a node16 base image)
  • frontend workflows have a reworked Install dependencies step that builds off PR fix(dashboard): centraldashboard-angular build with common-lib fetch #92 to ensure kubeflow-common-lib built and available
  • paths updated now that the testing folder does not live under the components/ folder
  • various manifests that reside in kubeflow/kubeflow under components/notebook-controller and components/crud-web-apps are provided to kustomize via their GitHub URL as those components weren't migrated to kubeflow/dashboard

TODO: Add .github/workflows/centraldb_angular_docker_publish.yaml once we are ready for publish/release.

@milinddethe15
Copy link
Member

/ok-to-test

@andyatmiami andyatmiami force-pushed the feat/centraldb-angular-ghas branch from 0207b2a to 4b19c24 Compare May 6, 2025 16:30
@andyatmiami
Copy link
Contributor Author

Part of kubeflow#74

Please note this PR makes a few modifications to the workflows:
- `node-version: 16` has been set for backend (previously `node-version: 12` in `kubeflow/kubeflow` although we build on a `node16` base image)
- `frontend` workflows have a reworked `Install dependencies` step that builds off PR kubeflow#92 to ensure `kubeflow-common-lib` built and available
- paths updated now that the `testing` folder does not live **under** the `components/` folder
- various manifests that reside in `kubeflow/kubeflow` under `components/notebook-controller` and `components/crud-web-apps` are provided to `kustomize` via their GitHub URL as those components weren't migrated to `kubeflow/dashboard`

TODO: Add .github/workflows/centraldb_angular_docker_publish.yaml once we are ready for publish/release.

Signed-off-by: Andy Stoneberg <[email protected]>
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8a8f0df into kubeflow:main Jun 3, 2025
5 of 6 checks passed
@juliusvonkohout
Copy link
Member

Sorry for the delay.
/lgtm
/approve

since the KSC soon wants to remove the old code. So we must have the ci/cd in kubeflwo/dashboard working, even if it is not perfect.

@kunal-511 do you mind checking whether you can update most tests according to what we have in Kubeflow/manifests and adjusting our sychronization scripts in / scripts for synchronizing from kubeflow/dashboard and kubeflow /notebooks instead of kubeflow/kubeflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants