Add api tests stateless by fege · Pull Request #1242 · kubeflow/hub

fege · 2025-06-24T07:53:39Z

Description

Add stateless and statefull test for the API, they are marked with fuzz, they can be run with make test-fuzz, the test will be run also in automatic way for main github.ref == 'refs/heads/main' or adding a label test-fuzz

How Has This Been Tested?

Merge criteria:

All the commits have been signed-off (To pass the DCO check)

The commits have meaningful messages
Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has manually tested the changes and verified that the changes work.
Code changes follow the kubeflow contribution guidelines.
For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

The developer has added tests or explained why testing cannot be added.
Included any necessary screenshots or gifs if it was a UI change.
Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Signed-off-by: fege <fmosca@redhat.com>

tarilabs · 2025-06-24T08:51:00Z

(sync'd with Federico offline for a small suggestion)

Signed-off-by: fege <fmosca@redhat.com>

lugi0

In general LGTM, however I do have a small comment on how additional data is fixed for the test.

google-oss-prow · 2025-06-24T09:14:58Z

@lugi0: changing LGTM is restricted to collaborators

Details

In response to this:

In general LGTM, however I do have a small comment on how additional data is fixed for the test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: fege <fmosca@redhat.com>

dbasunag · 2025-06-24T10:56:07Z

/lgtm

Signed-off-by: fege <fmosca@redhat.com>

…HOAIENG-26159-part1 Signed-off-by: fege <fmosca@redhat.com>

Signed-off-by: fege <fmosca@redhat.com>

…HOAIENG-26159-part1 Signed-off-by: fege <fmosca@redhat.com>

Signed-off-by: fege <fmosca@redhat.com>

…HOAIENG-26159-part1 Signed-off-by: fege <fmosca@redhat.com>

Signed-off-by: fege <fmosca@redhat.com>

Al-Pragliola

/lgtm

Signed-off-by: fege <fmosca@redhat.com>

Al-Pragliola

/lgtm

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

tarilabs · 2025-07-03T16:44:31Z

Thanks a lot really @fege for the efforts and this work, as well to all collaborations "offline" with @Al-Pragliola and QE folks

/lgtm
/approve

google-oss-prow · 2025-07-03T16:44:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tarilabs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

* Add api tests stateless Signed-off-by: fege <fmosca@redhat.com> * Fix github action failures, lint and nox Signed-off-by: fege <fmosca@redhat.com> * Add too_slow and remove code to force the model version id Signed-off-by: fege <fmosca@redhat.com> * Add filter_too_much Signed-off-by: fege <fmosca@redhat.com> * add hook to avoid Unsatisfiable Signed-off-by: fege <fmosca@redhat.com> * remove variable Signed-off-by: fege <fmosca@redhat.com> * add artifact_states Signed-off-by: fege <fmosca@redhat.com> * Add example to schema Signed-off-by: fege <fmosca@redhat.com> * Add example in src Signed-off-by: fege <fmosca@redhat.com> * register strategy for string of int64 Signed-off-by: fege <fmosca@redhat.com> * sort imports Signed-off-by: fege <fmosca@redhat.com> * modify case for problematic endpoints Signed-off-by: fege <fmosca@redhat.com> * add more examples Signed-off-by: fege <fmosca@redhat.com> * pin urllib Signed-off-by: fege <fmosca@redhat.com> * exclude problematic endpoints and test with valid data Signed-off-by: fege <fmosca@redhat.com> * Add gha to run the test and mark them with fuzz Signed-off-by: fege <fmosca@redhat.com> * revert change in Makefile pushed by error Signed-off-by: fege <fmosca@redhat.com> * skip test not marked with e2e or fuzz, trigger the fuzz on pr comment Signed-off-by: fege <fmosca@redhat.com> * trigger with label Signed-off-by: fege <fmosca@redhat.com> * correct the label name Signed-off-by: fege <fmosca@redhat.com> * add types and semplify the if Signed-off-by: fege <fmosca@redhat.com> * do not run e2e if test-fuzz label is added Signed-off-by: fege <fmosca@redhat.com> * unpin urllib Signed-off-by: fege <fmosca@redhat.com> * modify lock Signed-off-by: fege <fmosca@redhat.com> * fix: remove proc on label Signed-off-by: Alessio Pragliola <seth.pro@gmail.com> --------- Signed-off-by: fege <fmosca@redhat.com> Signed-off-by: Alessio Pragliola <seth.pro@gmail.com> Co-authored-by: Alessio Pragliola <seth.pro@gmail.com>

* Add api tests stateless Signed-off-by: fege <fmosca@redhat.com> * Fix github action failures, lint and nox Signed-off-by: fege <fmosca@redhat.com> * Add too_slow and remove code to force the model version id Signed-off-by: fege <fmosca@redhat.com> * Add filter_too_much Signed-off-by: fege <fmosca@redhat.com> * add hook to avoid Unsatisfiable Signed-off-by: fege <fmosca@redhat.com> * remove variable Signed-off-by: fege <fmosca@redhat.com> * add artifact_states Signed-off-by: fege <fmosca@redhat.com> * Add example to schema Signed-off-by: fege <fmosca@redhat.com> * Add example in src Signed-off-by: fege <fmosca@redhat.com> * register strategy for string of int64 Signed-off-by: fege <fmosca@redhat.com> * sort imports Signed-off-by: fege <fmosca@redhat.com> * modify case for problematic endpoints Signed-off-by: fege <fmosca@redhat.com> * add more examples Signed-off-by: fege <fmosca@redhat.com> * pin urllib Signed-off-by: fege <fmosca@redhat.com> * exclude problematic endpoints and test with valid data Signed-off-by: fege <fmosca@redhat.com> * Add gha to run the test and mark them with fuzz Signed-off-by: fege <fmosca@redhat.com> * revert change in Makefile pushed by error Signed-off-by: fege <fmosca@redhat.com> * skip test not marked with e2e or fuzz, trigger the fuzz on pr comment Signed-off-by: fege <fmosca@redhat.com> * trigger with label Signed-off-by: fege <fmosca@redhat.com> * correct the label name Signed-off-by: fege <fmosca@redhat.com> * add types and semplify the if Signed-off-by: fege <fmosca@redhat.com> * do not run e2e if test-fuzz label is added Signed-off-by: fege <fmosca@redhat.com> * unpin urllib Signed-off-by: fege <fmosca@redhat.com> * modify lock Signed-off-by: fege <fmosca@redhat.com> * fix: remove proc on label Signed-off-by: Alessio Pragliola <seth.pro@gmail.com> --------- Signed-off-by: fege <fmosca@redhat.com> Signed-off-by: Alessio Pragliola <seth.pro@gmail.com> Co-authored-by: Alessio Pragliola <seth.pro@gmail.com> Signed-off-by: Chanakya Thirumala Setty <cthiruma@redhat.com>

[pull] main from kubeflow:main

Add api tests stateless

23753e7

Signed-off-by: fege <fmosca@redhat.com>

google-oss-prow Bot requested review from Al-Pragliola and andreyvelich June 24, 2025 07:53

github-actions Bot added the Area/MR Python client label Jun 24, 2025

google-oss-prow Bot added the size/XL label Jun 24, 2025

Fix github action failures, lint and nox

28d329f

Signed-off-by: fege <fmosca@redhat.com>

lugi0 approved these changes Jun 24, 2025

View reviewed changes

Comment thread clients/python/tests/test_api.py Outdated

Add too_slow and remove code to force the model version id

e81a14a

Signed-off-by: fege <fmosca@redhat.com>

google-oss-prow Bot assigned dbasunag Jun 24, 2025

google-oss-prow Bot added the lgtm label Jun 24, 2025

fege marked this pull request as draft June 24, 2025 11:35

google-oss-prow Bot added the do-not-merge/work-in-progress label Jun 24, 2025

Add filter_too_much

f67b1a8

Signed-off-by: fege <fmosca@redhat.com>

google-oss-prow Bot removed the lgtm label Jun 24, 2025

dbasunag reviewed Jun 24, 2025

View reviewed changes

Comment thread clients/python/tests/test_api.py Outdated

fege added 3 commits June 25, 2025 11:55

add hook to avoid Unsatisfiable

25ef85b

Signed-off-by: fege <fmosca@redhat.com>

remove variable

7043310

Signed-off-by: fege <fmosca@redhat.com>

Merge branch 'main' of github.com:fege/model-registry-kubeflow into R…

631168d

…HOAIENG-26159-part1 Signed-off-by: fege <fmosca@redhat.com>

Al-Pragliola mentioned this pull request Jun 25, 2025

fix: stateless tests #1244

Merged

8 tasks

fege added 3 commits June 26, 2025 13:26

add artifact_states

09d24f9

Signed-off-by: fege <fmosca@redhat.com>

Merge branch 'main' of github.com:fege/model-registry-kubeflow into R…

1059bf7

…HOAIENG-26159-part1 Signed-off-by: fege <fmosca@redhat.com>

Add example to schema

e9ec8e3

Signed-off-by: fege <fmosca@redhat.com>

github-actions Bot added the Area/Go REST server label Jun 27, 2025

fege added 4 commits June 27, 2025 10:34

Add example in src

d8210c4

Signed-off-by: fege <fmosca@redhat.com>

register strategy for string of int64

9ff33ce

Signed-off-by: fege <fmosca@redhat.com>

sort imports

b785fcf

Signed-off-by: fege <fmosca@redhat.com>

Merge branch 'main' of github.com:fege/model-registry-kubeflow into R…

325f26f

…HOAIENG-26159-part1 Signed-off-by: fege <fmosca@redhat.com>

do not run e2e if test-fuzz label is added

57d7ecf

Signed-off-by: fege <fmosca@redhat.com>

tarilabs added test-fuzz and removed test-fuzz labels Jul 3, 2025

Al-Pragliola approved these changes Jul 3, 2025

View reviewed changes

google-oss-prow Bot assigned Al-Pragliola Jul 3, 2025

google-oss-prow Bot added the lgtm label Jul 3, 2025

tarilabs requested changes Jul 3, 2025

View reviewed changes

Comment thread clients/python/pyproject.toml Outdated

google-oss-prow Bot assigned tarilabs Jul 3, 2025

google-oss-prow Bot removed the lgtm label Jul 3, 2025

fege added 2 commits July 3, 2025 17:15

unpin urllib

7abe73c

Signed-off-by: fege <fmosca@redhat.com>

modify lock

47d67ea

Signed-off-by: fege <fmosca@redhat.com>

tarilabs added test-fuzz and removed test-fuzz labels Jul 3, 2025

fege requested a review from tarilabs July 3, 2025 16:12

Al-Pragliola reviewed Jul 3, 2025

View reviewed changes

google-oss-prow Bot added the lgtm label Jul 3, 2025

fix: remove proc on label

3454603

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>

google-oss-prow Bot removed the lgtm label Jul 3, 2025

google-oss-prow Bot added the lgtm label Jul 3, 2025

google-oss-prow Bot added the approved label Jul 3, 2025

google-oss-prow Bot merged commit 89af055 into kubeflow:main Jul 3, 2025
23 checks passed

fege mentioned this pull request Jul 4, 2025

change: Remove api tests moved to upstream opendatahub-io/opendatahub-tests#402

Merged

3 tasks

tarilabs mentioned this pull request Jul 4, 2025

periodic sync upstream KF to midstream ODH opendatahub-io/model-registry#244

Merged

fege mentioned this pull request Jul 7, 2025

Membership request for fege kubeflow/internal-acls#803

Closed

fege deleted the RHOAIENG-26159-part1 branch August 8, 2025 09:28

jonburdo pushed a commit to jonburdo/model-registry that referenced this pull request Feb 2, 2026

Merge pull request kubeflow#1242 from kubeflow/main

09aff8e

[pull] main from kubeflow:main

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add api tests stateless#1242

Add api tests stateless#1242
google-oss-prow[bot] merged 30 commits intokubeflow:mainfrom
fege:RHOAIENG-26159-part1

fege commented Jun 24, 2025 •

edited

Loading

Uh oh!

tarilabs commented Jun 24, 2025

Uh oh!

lugi0 left a comment

Uh oh!

Uh oh!

google-oss-prow Bot commented Jun 24, 2025

Uh oh!

dbasunag commented Jun 24, 2025

Uh oh!

Uh oh!

Al-Pragliola left a comment

Uh oh!

Uh oh!

Al-Pragliola left a comment

Uh oh!

tarilabs commented Jul 3, 2025

Uh oh!

google-oss-prow Bot commented Jul 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

fege commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Merge criteria:

Uh oh!

tarilabs commented Jun 24, 2025

Uh oh!

lugi0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

google-oss-prow Bot commented Jun 24, 2025

Uh oh!

dbasunag commented Jun 24, 2025

Uh oh!

Uh oh!

Al-Pragliola left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Al-Pragliola left a comment

Choose a reason for hiding this comment

Uh oh!

tarilabs commented Jul 3, 2025

Uh oh!

google-oss-prow Bot commented Jul 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fege commented Jun 24, 2025 •

edited

Loading