fix(bff): port to golangci-lint v2#948
Merged
google-oss-prow[bot] merged 2 commits intokubeflow:mainfrom Apr 7, 2025
Merged
Conversation
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
google-oss-prow
Bot
requested review from
Griffin-Sullivan,
alexcreasy and
andreyvelich
Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
alexcreasy
approved these changes
Apr 7, 2025
Member
alexcreasy
left a comment
alexcreasy
left a comment
There was a problem hiding this comment.
Great, thanks for the fix!
tarilabs
approved these changes
Apr 7, 2025
Member
tarilabs
left a comment
tarilabs
left a comment
There was a problem hiding this comment.
thanks a lot @Al-Pragliola for spotting this
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexcreasy, lucferbux, tarilabs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pboyd
pushed a commit
to pboyd/model-registry
that referenced
this pull request
Mar 19, 2026
…l docker digest to 8e3dcea (kubeflow#948) Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
port golangci-lint to v2 as the CI is failing for bff build after #919
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.