feat: remove linting/gen from dockerfile #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessio Pragliola <[email protected]>
Al-Pragliola
force-pushed
the
al-pragliola-change-build-process
branch
from
ef3a77d to
843a353
Compare
Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
pboyd
approved these changes
Jul 18, 2025
Member
pboyd
left a comment
pboyd
left a comment
There was a problem hiding this comment.
/lgtm
Seems like this should speed up our local image builds too.
rareddy
approved these changes
Jul 18, 2025
Contributor
rareddy
left a comment
rareddy
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Good work @Al-Pragliola!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rareddy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tarilabs
added a commit
to tarilabs/model-registry
that referenced
this pull request
Jul 19, 2025
follow-up to kubeflow#1334 The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml". Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593 The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure. Signed-off-by: Matteo Mortari <[email protected]>
8 tasks
google-oss-prow bot
pushed a commit
that referenced
this pull request
Jul 19, 2025
…ml (#1336) follow-up to #1334 The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml". Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593 The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure. Signed-off-by: Matteo Mortari <[email protected]>
Taj010
pushed a commit
to Taj010/model-registry
that referenced
this pull request
Aug 8, 2025
* feat: remove linting/gen from dockerfile Signed-off-by: Alessio Pragliola <[email protected]> * fix: missing checkout in action Signed-off-by: Alessio Pragliola <[email protected]> * fix: change prepare step Signed-off-by: Alessio Pragliola <[email protected]> * feat: make test target atomic Signed-off-by: Alessio Pragliola <[email protected]> * feat: make the jobs depend on prepare Signed-off-by: Alessio Pragliola <[email protected]> --------- Signed-off-by: Alessio Pragliola <[email protected]> Signed-off-by: Taj010 <[email protected]>
Taj010
pushed a commit
to Taj010/model-registry
that referenced
this pull request
Aug 8, 2025
…ml (kubeflow#1336) follow-up to kubeflow#1334 The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml". Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593 The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure. Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Taj010 <[email protected]>
Taj010
pushed a commit
to Taj010/model-registry
that referenced
this pull request
Aug 8, 2025
* feat: remove linting/gen from dockerfile Signed-off-by: Alessio Pragliola <[email protected]> * fix: missing checkout in action Signed-off-by: Alessio Pragliola <[email protected]> * fix: change prepare step Signed-off-by: Alessio Pragliola <[email protected]> * feat: make test target atomic Signed-off-by: Alessio Pragliola <[email protected]> * feat: make the jobs depend on prepare Signed-off-by: Alessio Pragliola <[email protected]> --------- Signed-off-by: Alessio Pragliola <[email protected]> Signed-off-by: Taj010 <[email protected]>
Taj010
pushed a commit
to Taj010/model-registry
that referenced
this pull request
Aug 8, 2025
…ml (kubeflow#1336) follow-up to kubeflow#1334 The build-and-push-image workflow was incorrectly calling the prepare.yml as a step action instead of using it as a reusable workflow. This caused the error "Can't find 'action.yml', 'action.yaml' or 'Dockerfile' under .github/workflows/prepare.yml". Example: https://github.com/kubeflow/model-registry/actions/runs/16379707719/job/46288348593 The prepare job is already correctly called at the top of the jobs section, so the duplicate call in the steps was unnecessary and likely the cause of the failure. Signed-off-by: Matteo Mortari <[email protected]> Signed-off-by: Taj010 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I move the linting/gen from the Dockerfile to the Github Action named prepare and make both the build workflow and the build and push workflow depend on it so every other Job that run docker build takes ~1minute instead of 5 and in general there's much less repetition in the actions
How Has This Been Tested?
run in CI
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.