-
Notifications
You must be signed in to change notification settings - Fork 145
Proposed OpenAPI spec changes for catalog administration #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Paul Boyd <[email protected]>
Signed-off-by: Paul Boyd <[email protected]>
765f6ae to
829b3ea
Compare
| properties: | ||
| type: object | ||
| description: Type-specific configuration properties | ||
| additionalProperties: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pboyd @chambridge do we know the structure of these additional properties? I imagine this is where we pass our huggingface allowedOrganization and apiKey, or our yaml for yaml-type sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's correct. The YAML source takes a yamlCatalogPath key.
For Hugging Face, the final version should be pretty close to what @adysenrothman has in #1852 (this file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The YAML source takes a yamlCatalogPath key.
that makes sense in the configmap since we'll also create a file containing the yaml in the configmap, but I'm referring to the stateless preview request - everything needs to be embedded here right? the user is inputting yaml they haven't saved yet so i don't think we have a path to refer to yet
Description
These are proposed changes to the API spec for the model catalog to support admin functions from the dashboard. Specifically, it adds:
This is not intended to be merged, but we can take these changes as a starting point for implementation.
How Has This Been Tested?
N/A
Merge criteria:
DCOcheck)