Skip to content

Conversation

@pboyd
Copy link
Member

@pboyd pboyd commented Nov 11, 2025

Description

These are proposed changes to the API spec for the model catalog to support admin functions from the dashboard. Specifically, it adds:

  • A new endpoint to preview changes to a catalog source
  • Unified fields for specifying models to include/exclude
  • Status and error fields for sources

This is not intended to be merged, but we can take these changes as a starting point for implementation.

How Has This Been Tested?

N/A

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pboyd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rareddy
Copy link
Contributor

rareddy commented Nov 12, 2025

fyi, @mturley @andrewballantyne

@pboyd pboyd force-pushed the catalog-admin-openapi-draft branch from 765f6ae to 829b3ea Compare November 13, 2025 14:25
Comment on lines +537 to +540
properties:
type: object
description: Type-specific configuration properties
additionalProperties: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pboyd @chambridge do we know the structure of these additional properties? I imagine this is where we pass our huggingface allowedOrganization and apiKey, or our yaml for yaml-type sources?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's correct. The YAML source takes a yamlCatalogPath key.

For Hugging Face, the final version should be pretty close to what @adysenrothman has in #1852 (this file).

Copy link
Contributor

@mturley mturley Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML source takes a yamlCatalogPath key.

that makes sense in the configmap since we'll also create a file containing the yaml in the configmap, but I'm referring to the stateless preview request - everything needs to be embedded here right? the user is inputting yaml they haven't saved yet so i don't think we have a path to refer to yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants