Skip to content

Remove Extra Pagination on model registry page #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chandanasirigineedi
Copy link
Contributor

Description

How Has This Been Tested?

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the broken build due to lint errors?

@ederign
Copy link
Member

ederign commented Apr 16, 2025

@jenny-s51 can you please review this one?

@ederign
Copy link
Member

ederign commented Apr 16, 2025

/assign @jenny-s51

Copy link
Member

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chandanasirigineedi, thanks so much for your contribution! 🎉

Since we’re using Patternfly, we want to stay aligned with their Pagination design guidelines.

I double checked with their design team, and they confirmed that we want to keep showing pagination at both the top and bottom - even for small datasets - for consistency across views.

An added benefit for this is that, when search filters are applied, having top pagination helps users quickly see the total result count without needing to scroll.

@SuryaSrikar would you be okay with us closing this PR and #965 ? We really appreciate you raising this - it's a thoughtful point, and we’re always open to more community input.

We’d love to see more contributions from you @chandanasirigineedi - feel free to check out other issues or open a discussion anytime! Thanks again 🚀

@chandanasirigineedi
Copy link
Contributor Author

chandanasirigineedi commented Apr 16, 2025

Hi @jenny-s51
Thank you so much for checking in with the PatternFly design team. In that case we will keep pagination at Top instead of bottom to make it user-friendly,

@chandanasirigineedi chandanasirigineedi force-pushed the remove-duplicate-pagenation-number branch from 8a92abb to d5b0485 Compare April 16, 2025 19:43
@SuryaSrikar
Copy link
Contributor

SuryaSrikar commented Apr 16, 2025

Hello @jenny-s51 , I wasn't initially aware of the pattern you're following. Generally, most web pages tend to have only one pagination section, so this approach is a bit new to me. I’m still getting familiar with the project.

After reviewing the Pagination design guidelines, the approach you're using does make sense. Thanks for pointing me in the right direction.

I'll go ahead and close my issue. Sorry @chandanasirigineedi for opening the wrong one and causing you work go in vain.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants