-
Notifications
You must be signed in to change notification settings - Fork 82
Remove Extra Pagination on model registry page #968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove Extra Pagination on model registry page #968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the broken build due to lint errors?
@jenny-s51 can you please review this one? |
/assign @jenny-s51 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @chandanasirigineedi, thanks so much for your contribution! 🎉
Since we’re using Patternfly, we want to stay aligned with their Pagination design guidelines.
I double checked with their design team, and they confirmed that we want to keep showing pagination at both the top and bottom - even for small datasets - for consistency across views.
An added benefit for this is that, when search filters are applied, having top pagination helps users quickly see the total result count without needing to scroll.
@SuryaSrikar would you be okay with us closing this PR and #965 ? We really appreciate you raising this - it's a thoughtful point, and we’re always open to more community input.
We’d love to see more contributions from you @chandanasirigineedi - feel free to check out other issues or open a discussion anytime! Thanks again 🚀
Hi @jenny-s51 |
8a92abb
to
d5b0485
Compare
Hello @jenny-s51 , I wasn't initially aware of the pattern you're following. Generally, most web pages tend to have only one pagination section, so this approach is a bit new to me. I’m still getting familiar with the project. After reviewing the Pagination design guidelines, the approach you're using does make sense. Thanks for pointing me in the right direction. I'll go ahead and close my issue. Sorry @chandanasirigineedi for opening the wrong one and causing you work go in vain. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
How Has This Been Tested?
Merge criteria:
DCO
check)ok-to-test
has been added to the PR.If you have UI changes