Skip to content

Remove Extra Pagination on model registry page #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Remove Extra Pagination on model registry page #968

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4469a5e
Remove Extra Pagination on model registry page
chandanasirigineedi Apr 13, 2025
3360769
added space for testing
chandanasirigineedi Apr 16, 2025
d5b0485
Remove Extra Pagination on model registry page
chandanasirigineedi Apr 16, 2025
4b1d67b
reverted the changes
chandanasirigineedi Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions clients/ui/frontend/src/shared/components/table/TableBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
const selectAllRef = React.useRef(null);
const showPagination = enablePagination;

const pagination = (variant: 'top' | 'bottom') => (
const pagination = (variant: 'bottom') => (
<Pagination
isCompact
{...(!disableItemCount && { itemCount })}
Expand Down Expand Up @@ -294,12 +294,11 @@
<ToolbarContent>
{toolbarContent}
{showPagination && (
<ToolbarItem

Check failure on line 297 in clients/ui/frontend/src/shared/components/table/TableBase.tsx

View workflow job for this annotation

GitHub Actions / test-and-build 

Empty components are self-closing
variant="pagination"
align={{ default: 'alignEnd' }}
className="pf-v6-u-pr-lg"
>

Check failure on line 301 in clients/ui/frontend/src/shared/components/table/TableBase.tsx

View workflow job for this annotation

GitHub Actions / test-and-build 

Delete `⏎··············`
{pagination('top')}
</ToolbarItem>
)}
</ToolbarContent>
Expand Down
Loading