-
Notifications
You must be signed in to change notification settings - Fork 43
feat(ws): complete api swagger documentation across workspaces, namespaces, and workspacekinds #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: notebooks-v2
Are you sure you want to change the base?
feat(ws): complete api swagger documentation across workspaces, namespaces, and workspacekinds #235
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
79bbc9b
to
82a95a0
Compare
/assign @ederign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
workspace-kinds
is not a valid URL segment - will result in 404
. value should be workspacekinds
- additionally
api/v1
segment appears 2x
vs.
$ curl --request GET --url http://localhost:4000/api/v1/workspacekinds -I
HTTP/1.1 200 OK
Access-Control-Allow-Origin: *
Content-Type: application/json
Date: Fri, 02 May 2025 20:36:32 GMT
Transfer-Encoding: chunked
@andyatmiami: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyatmiami: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
Signed-off-by: mohamed-ben-khemis <[email protected]>
799637b
to
5a3d225
Compare
Signed-off-by: mohamed-ben-khemis <[email protected]>
5a3d225
to
8ad2d55
Compare
Hi @andyatmiami, thanks for testing it out! 🙏 I’ve pushed a tiny update that resolves both of the problems you spotted: Removed the hyphen in the WorkspaceKinds route (changed workspace‑kinds → workspacekinds) so it no longer 404s (Swagger treats path segments literally). Eliminated the duplicate /api/v1 prefix by relying solely on swagger.SwaggerInfo.BasePath = "/api/v1" in docs.go, and dropping /api/v1 from each @router annotation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyatmiami: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closes #46
Summary
This PR continues the Swagger integration by adding complete Swagger documentation for all API endpoints.
Changes Implemented
/api/v1/swagger/index.html
.Notes