-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(backend): Add the ability to set a proxy for accessing external resources #11771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Skipping CI for Draft Pull Request. |
1adedcc
to
682e12a
Compare
98b14c8
to
b18ebfb
Compare
This is very useful and waiting for this PR to get merged. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments but this overall looks good!
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@HumairAK can you take another look? |
This is much required feature to us as we heavily involved in using corporate proxy. Thanks for this team. We would like to get this feature as early as possible. |
/retest |
…resources Signed-off-by: Helber Belmiro <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/retest |
1 similar comment
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #11744
Resolves #9702
Description of your changes:
This PR adds the ability to set a server-scoped proxy for accessing external resources.
Docs
Notes for reviewers
main
function when we create an instance ofproxy.Config
. The factory method handles the defaults for the unset values.argocompiler.workflowCompiler
that receivesproxy.Config
as a parameter. All existing fields are still optional.argocompiler.workflowCompiler.proxyConfig
is also optional sinceargocompiler.workflowCompiler
is a struct. But changing that to make it mandatory at compile time would increase the number of changes in this PR too much. We can do that in a follow-up PR if we think it's necessaryChecklist: