Skip to content

pipelines: Added proxy documentation #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

hbelmiro
Copy link
Contributor

@hbelmiro hbelmiro commented Mar 31, 2025

Checklist:

  • You have signed off your commits
  • Ensure you follow best practices from our guide. Contributing.
  • You have included screenshots when changing the website style or adding a new page.

Description of your changes:
This PR adds the documentation for proxy configuration.
The feature implementation is in:

Issue

Closes: kubeflow/pipelines#11744

Labels

/area pipelines


Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hbelmiro
Copy link
Contributor Author

@mprahl @HumairAK can you also take a look at this one please?

Comment on lines 91 to 236
valueFrom:
configMapKeyRef:
key: dbType
name: pipeline-install-config
- name: DBCONFIG_MYSQLCONFIG_USER
valueFrom:
secretKeyRef:
key: username
name: mysql-secret
- name: DBCONFIG_MYSQLCONFIG_PASSWORD
valueFrom:
secretKeyRef:
key: password
name: mysql-secret
- name: DBCONFIG_MYSQLCONFIG_DBNAME
valueFrom:
configMapKeyRef:
key: pipelineDb
name: pipeline-install-config
- name: DBCONFIG_MYSQLCONFIG_HOST
valueFrom:
configMapKeyRef:
key: mysqlHost
name: pipeline-install-config
- name: DBCONFIG_MYSQLCONFIG_PORT
valueFrom:
configMapKeyRef:
key: mysqlPort
name: pipeline-install-config
- name: OBJECTSTORECONFIG_ACCESSKEY
valueFrom:
secretKeyRef:
key: accesskey
name: mlpipeline-minio-artifact
- name: OBJECTSTORECONFIG_SECRETACCESSKEY
valueFrom:
secretKeyRef:
key: secretkey
name: mlpipeline-minio-artifact
image: kind-registry:5000/apiserver:latest
imagePullPolicy: IfNotPresent
livenessProbe:
exec:
command:
- wget
- -q
- -S
- -O
- '-'
- http://localhost:8888/apis/v1beta1/healthz
initialDelaySeconds: 3
periodSeconds: 5
timeoutSeconds: 2
name: ml-pipeline-api-server
ports:
- containerPort: 8888
name: http
- containerPort: 8887
name: grpc
readinessProbe:
exec:
command:
- wget
- -q
- -S
- -O
- '-'
- http://localhost:8888/apis/v1beta1/healthz
initialDelaySeconds: 3
periodSeconds: 5
timeoutSeconds: 2
resources:
requests:
cpu: 250m
memory: 500Mi
securityContext:
allowPrivilegeEscalation: false
capabilities:
drop:
- ALL
runAsGroup: 0
runAsNonRoot: true
runAsUser: 1000
startupProbe:
exec:
command:
- wget
- -q
- -S
- -O
- '-'
- http://localhost:8888/apis/v1beta1/healthz
failureThreshold: 12
periodSeconds: 5
timeoutSeconds: 2
securityContext:
seccompProfile:
type: RuntimeDefault
serviceAccountName: ml-pipeline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove this section because we don't want to have to keep this up to date as we change the manifests in the KFP repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

hbelmiro and others added 2 commits April 14, 2025 14:24
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Apr 14, 2025
@mprahl
Copy link
Contributor

mprahl commented Apr 14, 2025

/lgtm

@hbelmiro
Copy link
Contributor Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 5c9995d into kubeflow:master Apr 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add the ability to set a proxy for accessing external resources
2 participants